-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gex168 Modify all Phase2 scenarios after fixing the HCAL SD issue #42477
Conversation
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42477/36485
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e5077/34100/summary.html Comparison SummarySummary:
|
+geometry |
@srimanob Please approve this |
+Upgrade Change is seen in Phase-2 workflows as expected. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Modify all Phase2 scenarios after fixing the HCAL Sensitive Detector (SD) issue. The dd4hep was using some additional SDs which need not be in the list producing hits in HCAL. This was corrected in #42463 and these corrections are incorporated in this list. If this causes a serious impact on the simulation, it clearly indicates that this PR needs to be back ported to 13_2_X, 13_1_X, 13_0_X
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport will be decided later