Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-hcx352 Try to avoid wrong list of SD names of HCAL while using DD4hep #42463

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Aug 3, 2023

PR description:

ry to avoid wrong list of SD names of HCAL while using DD4hep

PR validation:

Tested using a script in Geometry/HcalCommonData/test/python

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42463/36466

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/HcalCommonData (geometry)
  • Geometry/HcalSimData (geometry)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 3, 2023

@cmsbuild Please test

@civanch
Copy link
Contributor

civanch commented Aug 3, 2023

@bsunanda , how this PR may affect 2022 and 2023 productions?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52cda1/34065/summary.html
COMMIT: 124d78d
CMSSW: CMSSW_13_3_X_2023-08-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42463/34065/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150799
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Aug 3, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 4, 2023

@civanch I really do not know the consequence. I hope this will avoid the mismatch of SD's from DDD and DD4hep for HCAL

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9bd8b0a into cms-sw:master Aug 4, 2023
@cmsbuild cmsbuild mentioned this pull request Aug 5, 2023
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 21, 2023
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_1_X due to issues in HCAL
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 21, 2023
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_1_X due to issues in HCAL
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 21, 2023
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_0_X due to issues in HCAL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants