-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-hcx352 Try to avoid wrong list of SD names of HCAL while using DD4hep #42463
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42463/36466
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
@bsunanda , how this PR may affect 2022 and 2023 productions? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52cda1/34065/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@civanch I really do not know the consequence. I hope this will avoid the mismatch of SD's from DDD and DD4hep for HCAL |
+1 |
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_1_X due to issues in HCAL
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_1_X due to issues in HCAL
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_0_X due to issues in HCAL
PR description:
ry to avoid wrong list of SD names of HCAL while using DD4hep
PR validation:
Tested using a script in Geometry/HcalCommonData/test/python
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special