Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex169 Modify the scenarios to have the right SimHit distributions for HF #42578

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

bsunanda
Copy link
Contributor

PR description:

Modify the scenarios to have the right SimHit distributions for HF

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42578/36598

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53e1df/34307/summary.html
COMMIT: f156e9e
CMSSW: CMSSW_13_3_X_2023-08-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42578/34307/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2958 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3152915
  • DQMHistoTests: Total failures: 5825
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3147068
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@bsunanda
Copy link
Contributor Author

+geometry

@srimanob
Copy link
Contributor

Hi @bsunanda
Do I understand correctly that the expected change from this PR is on Run-3 DD4hep XML only (11634.911). This is because the change of geometry is not yet propagated to GT, so no change is expected on normal workflow.

@bsunanda
Copy link
Contributor Author

@srimanob Yes the change is not propagated to the GT. 11634.911 uses XML and not the geometry from DB. So it is affected but not on workflows which get geometry from DB

@srimanob
Copy link
Contributor

+Upgrade

Change is expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7769acb into cms-sw:master Aug 17, 2023
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 21, 2023
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_1_X due to issues in HCAL
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 21, 2023
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_1_X due to issues in HCAL
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 21, 2023
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_0_X due to issues in HCAL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants