Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-hcx352B Add files to evaluate the impact of the changes made to the geometry scenarios due to SD issue in HCAL #42557

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

bsunanda
Copy link
Contributor

PR description:

Add files to evaluate the impact of the changes made to the geometry scenarios due to SD issue in HCAL

PR validation:

Made comparison with the old scenario

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42557/36573

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42557/36574

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/HcalCommonData (geometry)
  • SimG4CMS/Calo (simulation)

@makortel, @bsunanda, @civanch, @Dr15Jones, @mdhildreth can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @thomreis, @wang0jin, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-769eb8/34254/summary.html
COMMIT: 402bb97
CMSSW: CMSSW_13_3_X_2023-08-13-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42557/34254/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3152843
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3152815
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

+geometry

@civanch
Copy link
Contributor

civanch commented Aug 14, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0c9536a into cms-sw:master Aug 14, 2023
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 21, 2023
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_1_X due to issues in HCAL
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 21, 2023
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_1_X due to issues in HCAL
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 21, 2023
…ms-sw#42557, cms-sw#42578 to fix run3 scenario in CMSSW version 13_0_X due to issues in HCAL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants