Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT628] Root update v6 28 00 patches #8413

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_13_1_X/root628.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c6997/31673/summary.html
COMMIT: faaad18
CMSSW: CMSSW_13_1_ROOT628_X_2023-03-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8413/31673/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c6997/31673/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c6997/31673/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testDataFormatsScoutingRun2 had ERRORS
---> test testDataFormatsScoutingRun3 had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • You potentially removed 155 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554236
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 140
  • DQMHistoTests: Total successes: 3554071
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8.09 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.691 KiB L1T/L1TStage2uGMT
  • DQMHistoSizes: changed ( 11634.0,... ): 0.117 KiB L1TEMU/L1TdeStage2uGMT
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals
looks good, 2 unit tests are failing in IB and TestIOPoolInputNoParentDictionary normally fails for full cmssw PR tests . We need to see why it happens but will do it later

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/root628 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants