[GCC][PATCH] libstdc++: Mark non-exported function always_inline

[smuzaffar]

No description provided.

[smuzaffar]

test parameters:

• full_cmssw = true

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_5_X/g11.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[smuzaffar]

please test for CMSSW_12_5_LTO_X/el8_amd64_gcc11

[smuzaffar]

please test

[cmsbuild]

Pull request #8039 was updated.

[smuzaffar]

please test for CMSSW_12_5_LTO_X/el8_amd64_gcc11

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2fb0b/27079/summary.html
COMMIT: 6ad2851
CMSSW: CMSSW_12_5_LTO_X_2022-08-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8039/27079/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

[cmsbuild]

Pull request #8039 was updated.

[smuzaffar]

please test for CMSSW_12_5_LTO_X/el8_amd64_gcc11

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2fb0b/27082/summary.html
COMMIT: bc01287
CMSSW: CMSSW_12_5_LTO_X_2022-08-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8039/27082/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/pkgtools/scheduler.py", line 267, in doSerial
result = commandSpec[0](*commandSpec[1:])
File "./pkgtools/cmsBuild", line 3651, in installPackage
File "./pkgtools/cmsBuild", line 3399, in installRpm
RpmInstallFailed: Failed to install package autotools. Reason:
error: Failed dependencies:
	perl(IO::File) is needed by external+autotools+1.5-79adda178b626ec8c02bca65f28f6ddd-1-1.x86_64

* The action "build-external+xz+5.2.5-83d0a00b575efd1701e07bedf7977343" was not completed successfully because The following dependencies could not complete:
install-external+autotools+1.5-79adda178b626ec8c02bca65f28f6ddd
* The action "build-external+libffi+3.4.2-748f2aaa097b8c8addf5d86f14ac1fe6" was not completed successfully because The following dependencies could not complete:


[cmsbuild]

Pull request #8039 was updated.

[smuzaffar]

please test for CMSSW_12_5_LTO_X/el8_amd64_gcc11

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2fb0b/27108/summary.html
COMMIT: 87aee09
CMSSW: CMSSW_12_5_LTO_X_2022-08-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8039/27108/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @tvami Add new tag for PPS PCL, move SiStrips tags to Prod in DropBoxMetadata cmssw#39181
• @dmeuser Enable veto logic for HG PCL Tracker alignment cmssw#39189
• @forthommel [nT2] storing digis collection as edmNew::DetSetVector cmssw#39140
• @bsunanda Phase-hgx323Again Further correction for ring number assignment of scintillator hits in HGCal geometry for versions beyond V13 cmssw#39206
• @cecilecaillol [L1T] Phase-2, remove old simulation and adapt DQM cmssw#38442
• @makortel Declare production of Track collection after TrackExtra collection in modules run at HLT cmssw#39201
• @forthommel [nT2] zero-initialisation of TotemT2Digi members cmssw#39149
• @bsunanda Run3-hcx334 Take care of resulst from static analyser for Geometry/CaloTopology cmssw#39208
• @swagata87 Do NaN-check before accepting a PF candidate for computing photon's isolation cmssw#39120
• @kskovpen Update PU for Run3 wfs cmssw#39041
• @bsunanda Phase2-hgx322 Attempt to find the missing hits in the partial wafers in HGCalHESilicon section of the V17 geometry cmssw#39163
• @missirol allow TriggerResultsFilter to throw for invalid HLTPathStatus patterns cmssw#39044
• @bsunanda Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 cmssw#39164
• @fwyzard Clean unused dependencies from BuildFiles cmssw#39165
• @makortel Move PyBind11 interpreter management into its own sentry class cmssw#39157
• @cms-sw Revert "Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions V16 and V17" cmssw#39198
• @gartung Utilities/StaticAnalyzers: only report the use of TFileService functions if the parent function does not override a edm::one function cmssw#39153
• @mmusich modernize configuration of SiPixelGainCalibration DB manipulation code and add unit tests cmssw#39192
• @smorovic (DAQ) silence warnings in GlobalEvFOutputModule (12_5_X) cmssw#39191
• @cms-AlCaDB Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing cmssw#38760
• @ahussein1194 Adding time info to the rpc points extrapolated from the CSC and DT segments cmssw#39115
• @mmusich introduce unit tests for AlCaBeamSpotProducer and AlCaBeamSpotHarvester cmssw#39170
• @mmusich DiMuonMassBiasClient: add protection for empty input histogram in the fitting function cmssw#39173
• @bsunanda Run3-gex137 Change getByLabel to getByHandle in CalibMuon/DTCalibration cmssw#39172
• @missirol improve replacement of OutputModules in HLT ConfDB utilities cmssw#39177
• @bsunanda Run3-gex138 Replace getbylabel using token in CalibCalorimetry/CastorCalib cmssw#39176

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2fb0b/27108/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2fb0b/27108/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreSkeletons had ERRORS

Comparison Summary

Summary:

• You potentially added 47193 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 61985 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693084
• DQMHistoTests: Total failures: 401624
• DQMHistoTests: Total nulls: 165
• DQMHistoTests: Total successes: 3291273
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 908.4470000000001 KiB( 50 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 0.790 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 23234.0,... ): 113.398 KiB L1T/L1TPhase2
• DQMHistoSizes: changed ( 250202.181 ): 0.117 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.012 KiB SiStrip/MechanicalView
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: found differences in 16 / 50 workflows