Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 #39164

bsunanda · 2022-08-24T04:35:35Z

PR description:

Further correction for ring number assignment of scintillator hits in HGCal geometry versions V14, V15, V16 and V17

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a bug fix for all versions of HGCal geometry

… HGCal geometry versions V16 and V17

cmsbuild · 2022-08-24T04:45:55Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39164/31749

This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39164/31749/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39164/31749/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-08-24T04:56:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39164/31750

This PR adds an extra 52KB to repository

cmsbuild · 2022-08-24T04:56:31Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/CaloTopology (geometry)
Geometry/HGCalCommonData (geometry, upgrade)
SimG4CMS/Calo (simulation)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @beaucero, @trtomei, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2022-08-24T05:08:49Z

@cmsbuild Please test

cmsbuild · 2022-08-24T09:43:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f1384/27040/summary.html
COMMIT: 034bf8d
CMSSW: CMSSW_12_5_X_2022-08-23-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39164/27040/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 47146 lines to the logs
Reco comparison results: 2817 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3693084
DQMHistoTests: Total failures: 37996
DQMHistoTests: Total nulls: 5
DQMHistoTests: Total successes: 3655061
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

srimanob · 2022-08-25T03:08:50Z

type bug-fix

srimanob · 2022-08-25T03:12:46Z

Hi @bsunanda
Could you please elaborate more detail of the bug and this fix? This will help us to understand the situation more clearly.

Does the bug come after 12_4_0_pre4 as discussed in validation result, or it was there before?
If it was there before, how it is found? Do we have any kind of DQM that can spot on this? So that when new relvals come, validator can check on it.

Thanks.

bsunanda · 2022-08-25T03:35:34Z

This bug was there all the time. When the position at the border of 2 rings, it is usually referred to as the lower ring number. This is fine as long as there is no tile in the lower ring. We did not have a good valid test of a detid earlier. We have to introduce one now and that revealed the discrepancy. We do have detailed testing code in the repository and we do conduct them to look into details. The standard validation code can look into broad discrepancies so far and the detailed tests are better done by the experts of the geometry code.

civanch · 2022-08-25T10:14:21Z

+1

srimanob · 2022-08-25T15:38:46Z

+Upgrade

The fix should be followed up in validation.

cmsbuild · 2022-08-25T15:39:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-08-25T16:17:22Z

Geometry/HGCalCommonData/src/HGCalDDDConstants.cc

-          (iphi <= hgpar_->scintCells(layer)));
+  bool ok = ((irad >= hgpar_->iradMinBH_[indx.first]) && (irad <= (hgpar_->iradMaxBH_[indx.first] + 1)) && (iphi > 0) &&
+             (iphi <= hgpar_->scintCells(layer)));
+  return ((ok && trapezoidFile()) ? tileExist(zside, layer, irad, iphi) : ok);


To be correct, it should be

Suggested change

return ((ok && trapezoidFile()) ? tileExist(zside, layer, irad, iphi) : ok);

return ((ok && trapezoidFile()) ? tileExist(zside, layer, irad, iphi) : true);

(even if by now the net result is the same)

I don't think your correction is right - irrespective of trapezoidFile() the earlier test is good for all types of scintillators

I don't think your correction is right - irrespective of trapezoidFile() the earlier test is good for all types of scintillators

I understand that in practice ok && ok is identical to ok && true. But translating in C++ the sentence "irrespective of trapezoidFile() the earlier test is good for all types of scintillators" is exactly ok && true

perrotta · 2022-08-25T16:26:59Z

+1

Let have the bug fix in pre5. The incorrectness in Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 #39164 (review) should preferably get fixed in a follow up PR, though
Quite several changes in the 2026D77 35034 wf: as written in Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 #39164 (comment), it must be followed up in rhe validation

srimanob · 2022-08-25T16:31:13Z

By the way, I see failure in Static Check build log,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f1384/27040/llvm-analysis/runStaticChecks.log

Sorry that I miss to look on it when approved the PR.

srimanob · 2022-08-25T16:34:16Z

+1

Let have the bug fix in pre5. The incorrectness in Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions V16 and V17 #39164 (review) should preferably get fixed in a follow up PR, though

Quite several changes in the 2026D77 35034 wf: as written in Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions V16 and V17 #39164 (comment), it must be followed up in rhe validation

Hmm ... D77 is not expected for the change. There is nothing in PR mentioned about the effect on old geometry. I think this question should be answered first. I am very sorry to miss this when review. I mostly focused on D88 in private production and forget to look on PR test result.

perrotta · 2022-08-25T16:55:55Z

Indeed @srimanob , we were too quick

Let revert this, so that it won't pollute pre5: #39198

@bsunanda please redo the PR, and fix it by taking #39164 (comment) and #39164 (comment) into account (and also #39164 (review))

bsunanda · 2022-08-26T01:39:20Z

D77 is expected for the change - I mentioned V16 and V17 because they are to be kept for future. It will certainly affect V14 and V15 as well. D77 is V14

bsunanda · 2022-08-26T01:40:44Z

Please do not revert it. The static errors in topology is for debug. I shall take care of that as well as for HCAL stuff separately.

srimanob · 2022-08-26T02:30:39Z

Hi @bsunanda
Thanks for clarification. Please open the new PR.

bsunanda · 2022-08-26T02:47:17Z

Why a new PR with the same content - cannot be this one restored back?

…

________________________________ From: Phat Srimanobhas ***@***.*** Sent: 26 August 2022 04:30 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 (PR #39164) Hi @bsunanda<https://github.com/bsunanda> Thanks for clarification. Please open the new PR. — Reply to this email directly, view it on GitHub<#39164 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOVEU5QARQQUWQU6NR3V3AT5VANCNFSM57NZOHTQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

srimanob · 2022-08-26T02:49:19Z

I leave the technical part to @cms-sw/orp-l2 since this PR is merged already. I don't know if it is possible to do.

Further correction for ring number assignment of scintillator hits in…

cb292b0

… HGCal geometry versions V16 and V17

cmsbuild added this to the CMSSW_12_5_X milestone Aug 24, 2022

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Aug 24, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 24, 2022

Code check

034bf8d

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 24, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 24, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 24, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 24, 2022

cmsbuild added the bug-fix label Aug 25, 2022

cmsbuild added geometry-approved simulation-approved and removed simulation-pending geometry-pending labels Aug 25, 2022

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Aug 25, 2022

perrotta reviewed Aug 25, 2022

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Aug 25, 2022

cmsbuild merged commit 60996e5 into cms-sw:master Aug 25, 2022

perrotta mentioned this pull request Aug 25, 2022

Revert "Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions V16 and V17" #39198

Merged

bsunanda changed the title ~~Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions V16 and V17~~ Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 Aug 26, 2022

bsunanda mentioned this pull request Aug 26, 2022

Phase-hgx323Again Further correction for ring number assignment of scintillator hits in HGCal geometry for versions beyond V13 #39206

Merged

bsunanda deleted the Phase2-hgx323 branch August 26, 2022 03:25

cmsbuild mentioned this pull request Aug 26, 2022

[GCC][PATCH] libstdc++: Mark non-exported function always_inline cms-sw/cmsdist#8039

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 #39164

Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 #39164

bsunanda commented Aug 24, 2022 •

edited

Loading

cmsbuild commented Aug 24, 2022

cmsbuild commented Aug 24, 2022

cmsbuild commented Aug 24, 2022

bsunanda commented Aug 24, 2022

cmsbuild commented Aug 24, 2022

srimanob commented Aug 25, 2022

srimanob commented Aug 25, 2022

bsunanda commented Aug 25, 2022

civanch commented Aug 25, 2022

srimanob commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

perrotta Aug 25, 2022

bsunanda Aug 26, 2022

perrotta Aug 26, 2022

perrotta commented Aug 25, 2022

srimanob commented Aug 25, 2022

srimanob commented Aug 25, 2022 •

edited

Loading

perrotta commented Aug 25, 2022 •

edited

Loading

bsunanda commented Aug 26, 2022

bsunanda commented Aug 26, 2022

srimanob commented Aug 26, 2022

bsunanda commented Aug 26, 2022 via email

srimanob commented Aug 26, 2022

	return ((ok && trapezoidFile()) ? tileExist(zside, layer, irad, iphi) : ok);
	return ((ok && trapezoidFile()) ? tileExist(zside, layer, irad, iphi) : true);

Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 #39164

Phase2-hgx323 Further correction for ring number assignment of scintillator hits in HGCal geometry versions beyond V13 #39164

Conversation

bsunanda commented Aug 24, 2022 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Aug 24, 2022

cmsbuild commented Aug 24, 2022

cmsbuild commented Aug 24, 2022

bsunanda commented Aug 24, 2022

cmsbuild commented Aug 24, 2022

Comparison Summary

srimanob commented Aug 25, 2022

srimanob commented Aug 25, 2022

bsunanda commented Aug 25, 2022

civanch commented Aug 25, 2022

srimanob commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

perrotta Aug 25, 2022

Choose a reason for hiding this comment

bsunanda Aug 26, 2022

Choose a reason for hiding this comment

perrotta Aug 26, 2022

Choose a reason for hiding this comment

perrotta commented Aug 25, 2022

srimanob commented Aug 25, 2022

srimanob commented Aug 25, 2022 • edited Loading

perrotta commented Aug 25, 2022 • edited Loading

bsunanda commented Aug 26, 2022

bsunanda commented Aug 26, 2022

srimanob commented Aug 26, 2022

bsunanda commented Aug 26, 2022 via email

srimanob commented Aug 26, 2022

bsunanda commented Aug 24, 2022 •

edited

Loading

srimanob commented Aug 25, 2022 •

edited

Loading

perrotta commented Aug 25, 2022 •

edited

Loading