modernize configuration of SiPixelGainCalibration DB manipulation code and add unit tests

[mmusich]

PR description:

In response of #39012 (comment).
Modernized the configuration of several configuration files in CondTools/SiPixel and added them as test units.
Profited to add fillDescriptions methods for modules that were lacking it.

PR validation:

Relies on the successful running of the test units:

scram b runtests_SiPixelGainCalibrationTests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[mmusich]

type trk

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39192/31801

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondTools/SiPixel/test/SiPixelCondObjForHLTReader_cfg.py modified in PR(s): Deleting deprecated scripts access geometry with prior-run2 GT in CondTools/SiPixel #39012
  • File CondTools/SiPixel/test/SiPixelCondObjOfflineReader_cfg.py modified in PR(s): Deleting deprecated scripts access geometry with prior-run2 GT in CondTools/SiPixel #39012
  • File CondTools/SiPixel/test/SiPixelCondObjReader_cfg.py modified in PR(s): Deleting deprecated scripts access geometry with prior-run2 GT in CondTools/SiPixel #39012
  • File CondTools/SiPixel/test/SiPixelGainCalibrationRejectNoisyAndDead_cfg.py modified in PR(s): Deleting deprecated scripts access geometry with prior-run2 GT in CondTools/SiPixel #39012

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondTools/SiPixel (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39192/31803

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondTools/SiPixel/test/SiPixelCondObjForHLTReader_cfg.py modified in PR(s): Deleting deprecated scripts access geometry with prior-run2 GT in CondTools/SiPixel #39012
  • File CondTools/SiPixel/test/SiPixelCondObjOfflineReader_cfg.py modified in PR(s): Deleting deprecated scripts access geometry with prior-run2 GT in CondTools/SiPixel #39012
  • File CondTools/SiPixel/test/SiPixelCondObjReader_cfg.py modified in PR(s): Deleting deprecated scripts access geometry with prior-run2 GT in CondTools/SiPixel #39012
  • File CondTools/SiPixel/test/SiPixelGainCalibrationRejectNoisyAndDead_cfg.py modified in PR(s): Deleting deprecated scripts access geometry with prior-run2 GT in CondTools/SiPixel #39012

[cmsbuild]

Pull request #39192 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec545c/27094/summary.html
COMMIT: 42350aa
CMSSW: CMSSW_12_5_X_2022-08-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39192/27094/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693084
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3693048
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• newly introduced unit test succeed
• https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec545c/27094/unitTests/src/CondTools/SiPixel/test/SiPixelGainCalibrationTests/testing.log
• tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1