Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC13] Add include of cstdint in more places #42392

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

iarspider
Copy link
Contributor

Added missing cstdint includes to fix the GCC build errors about

error: 'uint32_t' does not name a type

This is a technical update

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42392/36413

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • CondFormats/PPSObjects (alca)
  • MagneticField/Interpolation (reconstruction)
  • RecoLocalCalo/HcalRecAlgos (reconstruction)
  • SimG4Core/PrintGeomInfo (simulation)
  • SimPPS/RPDigiProducer (simulation)

@perrotta, @consuegs, @civanch, @clacaputo, @saumyaphor4252, @mdhildreth, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@youyingli, @namapane, @apsallid, @grzanka, @missirol, @makortel, @slomeo, @tocheng, @argiro, @rchatter, @fabiocos, @bsunanda, @rovere, @thomreis, @wang0jin, @mmusich, @abdoulline, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-464924/33936/summary.html
COMMIT: 1498e87
CMSSW: CMSSW_13_3_X_2023-07-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42392/33936/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 17 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150799
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

ping

this is just a technical PR to fix missing include for GCC 13 builds

@civanch
Copy link
Contributor

civanch commented Jul 28, 2023

+1

@francescobrivio
Copy link
Contributor

+1

  • technical
  • all tests ok

@iarspider
Copy link
Contributor Author

@cms-sw/reconstruction-l2 gentle ping

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants