Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skims: definition, matrix, configBuilder - 76 #10134

Merged
merged 11 commits into from
Jul 12, 2015
Merged

skims: definition, matrix, configBuilder - 76 #10134

merged 11 commits into from
Jul 12, 2015

Conversation

franzoni
Copy link

forward port of #10133

alkaloge and others added 11 commits July 10, 2015 17:16
@alkaloge
backporting skims to 74x Conflicts resolved for: Configuration/Skimmi…
627e82a 
…ng/python/autoSkim.py
@alkaloge
1) autoskim, ZElectron skim
069e975 
2) Conflicts (resolved, only empty lines and verbose comment):	DPGAnalysis/Skims/python/Skims_DPG_cff.py	DPGAnalysis/Skims/python/ZElectronSkim_cff.py
3) exclute newly added Configuration/Skimming/autoSkim.py
autoSkimRunI introduced to keep track of legacy configuration Conflic…
e4bea0a 
…ts resolved:	Configuration/Skimming/python/autoSkim.py
skim matrix for runII; keys are PD names for 50ns run, see https://hy…
5d983a3 
…pernews.cern.ch/HyperNews/CMS/get/physics-announcements/3385.html
remove module duplication conflict : PDWG_EXOHSCP <-> reco step
0a9dc2f
remove module duplication conflict : WElectronSkim <-> reco step
568ac7f
enable skims for Cosmics PD; DT skim does not exist/function
88614fe
remove autoSkim.py accidentaly brought in by cherry-pick
87c872d
add LogErrorMonitor
9bc08ff
preserve output modules set by --eventcontent when SKIM is in the seq…
049fcf0 
…uence
remove conflicts in HighMETSkim and ZMuSkim
8a8c6a9
@franzoni
Copy link
Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Jul 10, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_7_6_X.

skims: definition, matrix, configBuilder - 76

It involves the following packages:

Configuration/Applications
Configuration/Skimming
DPGAnalysis/Skims

@cmsbuild, @srimanob, @boudoul, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10134/6127/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 12, 2015
@cmsbuild
Merge pull request #10134 from franzoni/GF_Skims_RETRY-CMSSW_7_6_X_20…
06f3104 
…15-07-10-1100

skims: definition, matrix, configBuilder - 76
@cmsbuild cmsbuild merged commit 06f3104 into cms-sw:CMSSW_7_6_X Jul 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed operations-approved pdmv-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
4 participants
@franzoni @cmsbuild @davidlange6 @alkaloge