-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1 Stage 1 MET fixes #11372
L1 Stage 1 MET fixes #11372
Conversation
A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_6_X. L1 Stage 1 MET fixes It involves the following packages: L1Trigger/L1TCalorimeter @cmsbuild, @mulhearn can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
L1 Stage 1 MET fixes (75X backport of #11372 )
L1 Stage 1 MET fixes (74X backport of #11372 )
The L1 ET sum emulator algorithm requires some changes to the handling of overflow regions to agree with firmware. These changes were tested with Ben Kreis on the firmware side.
The changes are in response to differences between L1 firmware and DQM re-emulation that were found. This will need to be back-ported to 75X and 74X as well.