Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For HI HLT: migration of 5 HI tracking modules to stream modules (75X backport) #11604

Conversation

kkrajczar
Copy link
Contributor

This PR is a 75X backport of #11603.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

A new Pull Request was created by @kkrajczar (Krisztian Krajczar) for CMSSW_7_5_X.

For HI HLT: migration of 5 HI tracking modules to stream modules (75X backport)

It involves the following packages:

RecoHI/HiTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @echapon, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 1, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@slava77
Copy link
Contributor

slava77 commented Oct 5, 2015

+1

for #11604 9f01ed3

  • code changes are in line with the PR description. The modules are in fact also running in regular HI RECO and make up for just under 1% of CPU there.
  • jenkins tests pass and comparisons with baseline show no difference

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 12, 2015
…TrackingModules75X

For HI HLT: migration of 5 HI tracking modules to stream modules (75X backport)
@cmsbuild cmsbuild merged commit 38915aa into cms-sw:CMSSW_7_5_X Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants