Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed API for RefGetter and LazyGetter from EcalRegionCabling #11788

Conversation

Dr15Jones
Copy link
Contributor

There is no code in CMSSW which called the member functions of
EcalRegionCabling that took RefGetter and LazyGetter as arguments.
Given the Getter classes have thread-safety issues we want to
minimize classes which depend upon them.

There is no code in CMSSW which called the member functions of
EcalRegionCabling that took RefGetter and LazyGetter as arguments.
Given the Getter classes have thread-safety issues we want to
minimize classes which depend upon them.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Removed API for RefGetter and LazyGetter from EcalRegionCabling

It involves the following packages:

EventFilter/EcalRawToDigi

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8839/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 3408c1f
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11788/8839/summary.html

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8846/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11788 3408c1f

Deleting unused, thread-unsafe code for EcalRegionCabling. There should be no change in run-time behavior.

Jenkins tests against baseline CMSSW_7_6_X_2015-10-14-1600 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 19, 2015
…egionCabling

Removed API for RefGetter and LazyGetter from EcalRegionCabling
@cmsbuild cmsbuild merged commit b5d4985 into cms-sw:CMSSW_7_6_X Oct 19, 2015
@Dr15Jones Dr15Jones deleted the removeLazyGetterAPIFromEcalRegionCabling branch October 19, 2015 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants