-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use preferred form of not-equal since python 3 eliminates <> #11960
Conversation
A new Pull Request was created by @ericvaandering (Eric Vaandering) for CMSSW_8_0_X. Use perferred form of not-equal since python 3 eliminates <> It involves the following packages: DQM/HcalMonitorModule @smuzaffar, @Dr15Jones, @cvuosalo, @cmsbuild, @deguio, @slava77, @vanbesien, @danduggan can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
+1 |
The tests are being triggered in jenkins. |
Should we also cook CMSSW + Python 3.5 IB? |
do we know what externals do / do not support it ?
|
No. Will break for sure as the point of these patches is to get the python as compatible as can be with 3.x while not breaking 2.6 compatibility. Actual python3 compatibility is a whole different animal. |
@davidlange6 most of Python packages we ship are not required for CMSSW execution, but it's easy to check since Python 3 is default in Fedora 23. Most critical part is to make sure Framework + Python 3 is fine. Most of other changes should be mechanical. I can experiment with that a bit on personal branch to see what works or not. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Use preferred form of not-equal since python 3 eliminates <>
@Dr15Jones said 8_0_X would be a decent place to start getting rid of old python that is not compatible with python 3 but works fine in 2.6/2.7.