-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modification to #11868 (configuring flat BS + DQM GUI) #11998
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC. Modification to #11868 (configuring flat BS + DQM GUI) It involves the following packages: Configuration/PyReleaseValidation @civanch, @danduggan, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks. |
looks great, thanks |
Hi Mark - did you need more requests to finalize the SLHC release?
|
merge @davidlange6 no this is everything. Sorry, got tied up with other things. As soon as the bot merges this I'll put in the request (EDIT- ... for the release). |
Modification to #11868 (configuring flat BS + DQM GUI)
This is a slight change to pull request #11868, where the
bsStudyStep1
andbsStudyStep2
functions are merged into onebsStudy
function, withhasattr
guards to select the right parts. This should make it easier to use.I'll start the auto tests, but they don't use the new customisation functions so I've already tested privately with:
(basically upgrade workflow 15600 but with
customise_bsStudy_15
customisation and the beamspot set toFlat
). And:(
cust_2023HGCalMuon
has to be respecified, since the new customise command overrides the original). Everything runs fine and the correct parameters are changed.@boudoul