Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification to #11868 (configuring flat BS + DQM GUI) #11998

Merged
merged 2 commits into from
Oct 21, 2015

Conversation

mark-grimes
Copy link

This is a slight change to pull request #11868, where the bsStudyStep1 and bsStudyStep2 functions are merged into one bsStudy function, with hasattr guards to select the right parts. This should make it easier to use.

I'll start the auto tests, but they don't use the new customisation functions so I've already tested privately with:

cmsDriver.py FourMuPt_1_200_cfi --conditions PH2_1K_FB_V6::All -n 10 --eventcontent FEVTDEBUG --relval 10000,100 -s GEN,SIM --datatier GEN-SIM --beamspot Flat --customise RecoParticleFlow/PandoraTranslator/customizeHGCalPandora_cff.cust_2023HGCalPandoraMuon,SLHCUpgradeSimulations/Configuration/combinedCustoms.customise_bsStudy_15 --geometry Extended2023HGCalMuon,Extended2023HGCalMuonReco --magField 38T_PostLS1 --no_exec --fileout file:step1.root
cmsDriver.py step2 --conditions PH2_1K_FB_V6::All -n 10 --eventcontent FEVTDEBUGHLT -s DIGI:pdigi_valid,L1,DIGI2RAW --datatier GEN-SIM-DIGI-RAW --customise RecoParticleFlow/PandoraTranslator/customizeHGCalPandora_cff.cust_2023HGCalPandoraMuon,SLHCUpgradeSimulations/Configuration/combinedCustoms.customise_bsStudy_15 --geometry Extended2023HGCalMuon,Extended2023HGCalMuonReco --magField 38T_PostLS1 --no_exec --filein file:step1.root --fileout file:step2.root
cmsDriver.py step3 --conditions PH2_1K_FB_V6::All -n 10 --eventcontent RECOSIM -s RAW2DIGI,L1Reco,RECO --datatier GEN-SIM-RECO --customise RecoParticleFlow/PandoraTranslator/customizeHGCalPandora_cff.cust_2023HGCalPandoraMuon,SLHCUpgradeSimulations/Configuration/combinedCustoms.customise_bsStudy_15 --geometry Extended2023HGCalMuon,Extended2023HGCalMuonReco --magField 38T_PostLS1 --no_exec --filein file:step2.root --fileout file:step3.root

(basically upgrade workflow 15600 but with customise_bsStudy_15 customisation and the beamspot set to Flat). And:

runTheMatrix.py -w upgrade -l 12200 --command="--beamspot Flat --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_2023HGCalMuon,SLHCUpgradeSimulations/Configuration/combinedCustoms.customise_bsStudy_15"

(cust_2023HGCalMuon has to be respecified, since the new customise command overrides the original). Everything runs fine and the correct parameters are changed.

@boudoul

@mark-grimes
Copy link
Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_6_2_X_SLHC milestone Oct 20, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9072/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Modification to #11868 (configuring flat BS + DQM GUI)

It involves the following packages:

Configuration/PyReleaseValidation
SLHCUpgradeSimulations/Configuration

@civanch, @danduggan, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@boudoul
Copy link
Contributor

boudoul commented Oct 20, 2015

looks great, thanks

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

Hi Mark - did you need more requests to finalize the SLHC release?

On Oct 20, 2015, at 7:45 PM, cmsbuild notifications@github.com wrote:

+1
Tested at: 6472d4d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11998/9072/summary.html


Reply to this email directly or view it on GitHub.

@mark-grimes
Copy link
Author

merge

@davidlange6 no this is everything. Sorry, got tied up with other things. As soon as the bot merges this I'll put in the request (EDIT- ... for the release).

cmsbuild added a commit that referenced this pull request Oct 21, 2015
Modification to #11868 (configuring flat BS + DQM GUI)
@cmsbuild cmsbuild merged commit cbf4d0d into cms-sw:CMSSW_6_2_X_SLHC Oct 21, 2015
@mark-grimes mark-grimes deleted the modifyBS_flat branch October 21, 2015 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants