Removed static analyzer errors from RecoLocalTracker

[nickmccoll]

SiStripTemplateSplit.cc
Unused variables

StripCPEfromTemplate.cc
Unnecessary const cast

TrackClusterSplitter.cc
This currentAmpl value is not used (it is set to another value at around line 710)

[cmsbuild]

A new Pull Request was created by @nickmccoll (Nick McColl) for CMSSW_8_0_X.

Removed static analyzer errors from RecoLocalTracker

It involves the following packages:

RecoLocalTracker/SiStripRecHitConverter
RecoLocalTracker/SubCollectionProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @jlagram, @gpetruc, @cerati, @threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9107/console

[cmsbuild]

-1
Tested at: 1324e56
When I ran the RelVals I found an error in the following worklfows:
1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 21-Oct-2015 19:59:54 CEST-----------------------
An exception of category 'FileReadError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Reading branch EventAuxiliary
   [3] Calling XrdFile::readv()
   [4] XrdAdaptor::ClientRequest::HandleResponse() failure while running connection recovery
   [5] In XrdAdaptor::RequestManager::requestFailure()
Exception Message:
XrdAdaptor::RequestManager::requestFailure Open(name='root://eoscms.cern.ch//eos/cms/store/data/Run2012A/MinimumBias/RAW/v1/000/191/226/02F7EB61-0986-E111-A66F-5404A63886B4.root', flags=0x10, permissions=0660, old source=lxfsrd06c04.cern.ch:1095 (unknown site)) => timeout when waiting for file open
   Additional Info:
      [a] Original error: '[ERROR] Operation expired' (errno=0, code=206, source=lxfsrd06c04.cern.ch:1095 (unknown site)).
      [b] Disabled source: lxfsrd06c04.cern.ch:1095
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12026/9107/summary.html

[slava77]

@cmsbuild please test
maybe a glitch

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9112/console

[cmsbuild]

-1
Tested at: 1324e56
When I ran the RelVals I found an error in the following worklfows:
1001.0 step3

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step3_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12026/9112/summary.html

[slava77]

@cmsbuild please test
this is more of infrastructure testing than the PR testing

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9118/console

[cmsbuild]

+1
Tested at: 1324e56
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12026/9118/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12026/9118/summary.html

[slava77]

+1

for #12026 1324e56

• technical changes addressing static analyzer issues
• the same code diffs as in 76X
• jenkins tests pass and comparisons with baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1