fixing bug for cut-based jet pu ID #12053

jbrands · 2015-10-22T15:27:21Z

This PR uses the new weight names from cms-data/RecoJets-JetProducers#6 to fix the bug for cut based pu ID. The names of offline and online pu ID are now the same. Nevertheless,this PR targets mainly the offline pu ID. The fix includes that cut-based variables have the same name as MVA variables as well as including the pull variable in the offline pu ID. The code was tested and gives reasonable values for all variables (online and offline) before running the MVA.

cmsbuild · 2015-10-22T15:31:10Z

A new Pull Request was created by @jbrands for CMSSW_7_6_X.

From cmssw 7 6 0 pre7 jbrands

It involves the following packages:

DataFormats/JetReco
RecoJets/JetProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @yslai, @TaiSakuma, @ahinzmann, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

slava77 · 2015-10-22T15:31:19Z

@cmsbuild please test

@jbrands please submit a PR to 80X as well (in case there are delays in integration to 76X)

cmsbuild · 2015-10-22T15:36:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9137/console

cmsbuild · 2015-10-22T17:44:51Z

-1
Tested at: 699ddc3
When I ran the RelVals I found an error in the following worklfows:
4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12053/9137/summary.html

slava77 · 2015-10-22T20:02:15Z

--- <FATAL> BDTG                     : The expression declared to the Reader needs to be checked (name or order are wrong)
***> abort program execution

I suppose, the very latest cms-data/RecoJets-JetProducers#6 should be available first, before this can be tested.
For some reason I thought that cms-data/RecoJets-JetProducers#5 was already with the right names.
@jbrands please confirm.

jbrands · 2015-10-22T21:19:36Z

@slava77 Unfortunately this PR cms-data/RecoJets-JetProducers#6 was necessary again because I still had to rename some variables to avoid confusion and cms-data/RecoJets-JetProducers#5 was not enough. So with cms-data/RecoJets-JetProducers#6 in the code everything should run. I use the new weight files from this PR

slava77 · 2015-10-25T19:14:12Z

@cmsbuild please test

cmsbuild · 2015-10-25T19:16:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9178/console

cmsbuild · 2015-10-25T19:16:40Z

Pull request #12053 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

cmsbuild · 2015-10-25T21:22:56Z

+1
Tested at: c6125cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12053/9178/summary.html

slava77 · 2015-10-27T22:17:50Z

RecoJets/JetProducers/src/PileupJetIdAlgo.cc

+	  float dphi = reco::deltaPhi(*part, *jet);
+	  float ddeta, ddphi, ddR;
+	  ddeta = deta - ave_deta ;
+	  ddphi = dphi-ave_dphi;


reco::deltaPhi(dphi, ave_dphi)
unless you are sure this is always small (neither dphi nor ave_dphi goes above pi/2; which is probably correct, considering the constituents are a part of the jet)
[my per-commit comment may go unnoticed]

slava77 · 2015-10-27T22:18:22Z

@cmsbuild please test

cmsbuild · 2015-10-27T22:21:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9247/console

cmsbuild · 2015-10-27T22:21:37Z

Pull request #12053 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

cmsbuild · 2015-10-28T00:47:34Z

+1
Tested at: 832c2c0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12053/9247/summary.html

slava77 · 2015-10-28T01:49:29Z

+1

for #12053 832c2c0

changes in the code look OK (parts are in line with my earlier findings of previously inconsistent use of variables)
jenkins tests pass and comparisons with baseline show differences only in PU ID variables (plots in DQM)
additionally tested locally with 134.* workflows for 2015B and 2015C:
- the smaller statistics results from jenkins tests are confirmed;
- the last commits 832c2c0 compared to c6125cc give identical results on 134.705 and 134.805

plots suggest a better separation of PU jets (red is with this PR):
134.802 (2015C DoubleEG)

smaller effect/difference for higher pt jets

cmsbuild · 2015-10-28T01:51:19Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-10-28T01:53:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12053/9247/summary.html

cmsbuild · 2015-10-28T01:56:19Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-10-28T08:15:28Z

+1

fixing bug for cut-based jet pu ID

jbrands added 3 commits October 21, 2015 16:34

offline fix for cut-based jet id

63b0b1d

fix for full_74x_wp

87fde89

changing DR_weightd to dRMean

699ddc3

jbrands mentioned this pull request Oct 22, 2015

new weight files cms-data/RecoJets-JetProducers#6

Merged

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 22, 2015

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 22, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 22, 2015

jbrands changed the title ~~From cmssw 7 6 0 pre7 jbrands~~ fixing bug for cut-based jet pu ID Oct 22, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 22, 2015

adding delete statement to the PileupJetIdProducer

c6125cc

cmsbuild added tests-pending and removed tests-rejected labels Oct 25, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 25, 2015

slava77 reviewed Oct 27, 2015
View reviewed changes

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Oct 27, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 27, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 28, 2015

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures reconstruction-pending labels Oct 28, 2015

slava77 mentioned this pull request Oct 28, 2015

fixing bug for cut-based jet pu ID #12054

Merged

cmsbuild added comparison-available and removed comparison-pending labels Oct 28, 2015

cmsbuild added orp-approved and removed orp-pending labels Oct 28, 2015

cmsbuild added a commit that referenced this pull request Oct 28, 2015

Merge pull request #12053 from jbrands/from-CMSSW_7_6_0_pre7-jbrands

deaf58f

fixing bug for cut-based jet pu ID

cmsbuild merged commit deaf58f into cms-sw:CMSSW_7_6_X Oct 28, 2015

ahinzmann mentioned this pull request Nov 12, 2015

Backport offline PU ID fix from #12053 to 74 #12398

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixing bug for cut-based jet pu ID #12053

fixing bug for cut-based jet pu ID #12053

jbrands commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

slava77 commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

slava77 commented Oct 22, 2015

jbrands commented Oct 22, 2015

slava77 commented Oct 25, 2015

cmsbuild commented Oct 25, 2015

cmsbuild commented Oct 25, 2015

cmsbuild commented Oct 25, 2015

slava77 Oct 27, 2015

slava77 commented Oct 27, 2015

cmsbuild commented Oct 27, 2015

cmsbuild commented Oct 27, 2015

cmsbuild commented Oct 28, 2015

slava77 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

davidlange6 commented Oct 28, 2015

fixing bug for cut-based jet pu ID #12053

fixing bug for cut-based jet pu ID #12053

Conversation

jbrands commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

slava77 commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

slava77 commented Oct 22, 2015

jbrands commented Oct 22, 2015

slava77 commented Oct 25, 2015

cmsbuild commented Oct 25, 2015

cmsbuild commented Oct 25, 2015

cmsbuild commented Oct 25, 2015

slava77 Oct 27, 2015

Choose a reason for hiding this comment

slava77 commented Oct 27, 2015

cmsbuild commented Oct 27, 2015

cmsbuild commented Oct 27, 2015

cmsbuild commented Oct 28, 2015

slava77 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

davidlange6 commented Oct 28, 2015