-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alca beam spot harvester fix v2 #12069
Alca beam spot harvester fix v2 #12069
Conversation
… a too small sigmaZ values. Default cut is at 1 cm
… a too small sigmaZ values. Default cut is at 1 cm
… a too small sigmaZ values. Default cut is at 1 cm
… a too small sigmaZ values. Default cut is at 1 cm
A new Pull Request was created by @gennai (simone gennai) for CMSSW_7_4_X. Alca beam spot harvester fix v2 It involves the following packages: Calibration/TkAlCaRecoProducers @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
-1 you can see the results of the tests here: |
please test |
@gennai are the forward ports available? |
The tests are being triggered in jenkins. |
I see they are... the bot wasn't noticing. Sorry for the noise. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Alca beam spot harvester fix v2
Fix needed to avoid to consider LS with too small sigmaZ Beam Spot values.