80X - Fix for handling of rare cases of CSC CFEB data corruptions with incorrect 16 samples flag reporting

[barvic]

80X - Fix for handling of rare cases of CSC CFEB data corruptions with incorrect 16 samples flag reporting.

• Limit CSC CFEB maximum expected and unpacked samples to 8, to prevent CSC RECO assertion failures, when CFEBs send corrupted data with 16 samples flag set.

Refer to https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1395.html thread.

74X - PR #12186

[cmsbuild]

A new Pull Request was created by @barvic for CMSSW_8_0_X.

80X - Fix for handling of rare cases of CSC CFEB data corruptions with incorrect 16 samples flag reporting

It involves the following packages:

EventFilter/CSCRawToDigi

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9352/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9356/console

[cmsbuild]

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9352/console

[cmsbuild]

+1
Tested at: b31847e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12190/9356/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12190/9356/summary.html

[cvuosalo]

+1

For #12190 b31847e

Bug fix to handle rare cases of CSC CFEB data corruption. There should be no change in monitored quantities. #12186, #12187, and #12188 are the 74X, 75X, and 76X versions of this PR, and they have already been approved by Reco.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2015-10-29-1100 show no significant differences, as expected. The fix was verified for #12186.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1