protect RawTask::_process from processing bad HcalHTRData #14963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @dan131riley (Dan Riley) for CMSSW_8_1_X. It involves the following packages: DQM/HcalTasks @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
I realize we see this error in tier0. @dmitrijus any problems with the PR? |
|
please test |
|
The tests are being triggered in jenkins. |
|
@dan131riley - could you make a 80x PR for this fix? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RawTask::_process() doesn't check the validity of the HcalHTRData from getSpigotData(), which can result in invalid memory accesses if the data are corrupt or missing. This is seen in valgrind for some IB workflows, e.g. 134.703, and is suspected of causing intermittent crashes in the threaded IBs. Details are in issue #14898. This PR proposes a minimal point fix, copying a pattern used elsewhere in the HCAL DQM.
From the IB log files, it looks like the input file (from step2) for this workflow is missing most of the collections needed by step3; perhaps there ought to be some higher level check that would skip processing missing data altogether, but that's out of scope for this PR.