include hcalRecAlgos ES producer in cosmic workflow [84X]

[kpedro88]

Backport of #17782

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_4_X.

It involves the following packages:

RecoLocalCalo/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18170/console Started: 2017/03/06 17:53
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18171/console Started: 2017/03/06 18:06

[cmsbuild]

-1

Tested at: db23b22

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f77247c
b8815bc
2ce390f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17784/18171/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17784/18171/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17784/18171/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f77247c
b8815bc
2ce390f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17784/18171/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17784/18171/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[slava77]

The release you are using, "CMSSW_8_4_0_patch1" , predates
a release ("CMSSW_9_0_0_pre4") used in writing the input file, root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_0_0_pre4/RelValMinBias_13/GEN-SIM/90X_mcRun2_asymptotic_v1-v1/10000/020D6CED-73EA-E611-8ED3-0025905B855A.root.
Forward compatibility cannot be supported.

@Dr15Jones it looks like we need some fix here from the framework side

[davidlange6]

I don't think there is a "problem" to fix.

[slava77]

On 3/7/17 2:53 AM, David Lange wrote: I don't think there is a "problem" to fix.

Just to understand more clearly: we will not allow reading 900pre4 files (830-equivalent) in 84X releases. Correct?

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17784 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbgUv9xWsJ-t50sXZXaxYdZD-Ltotks5rjTcvgaJpZM4MTlTj>.

[davidlange6]

I don't think we should change the fwk to allow it, no (but that said, the short matrix ran when I built 840 and 840patch1, so perhaps the check is not as reliable as it should be:) ) anyway, 840 is a hack for mwgr2/3

…

On Mar 7, 2017, at 3:12 PM, Slava Krutelyov ***@***.***> wrote: On 3/7/17 2:53 AM, David Lange wrote: > I don't think there is a "problem" to fix. > Just to understand more clearly: we will not allow reading 900pre4 files (830-equivalent) in 84X releases. Correct? > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#17784 (comment)>, or > mute the thread > <https://github.com/notifications/unsubscribe-auth/AEdcbgUv9xWsJ-t50sXZXaxYdZD-Ltotks5rjTcvgaJpZM4MTlTj>. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[perrotta]

+1
In CMSSW_8_4_X the same crash observed in cosmic workflows in 90X and 91X does not (yet) shows up,
However, the HcalRecAlgos are included in the 84X cosmics configs only through some of the otherwise redundant AlCa steps in these workflows, as pointed out by @kpedro88 in #17782 (comment) .
Therefore, this PR which correctly includes HcalRecAlgos in the RecoLocalCalo_Cosmics config is needed for robustness (at least).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_4_X IBs (but tests are reportedly failing).