Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HCAL TP compression LUTs by populating plan 1 TP list first. #17790

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Fix HCAL TP compression LUTs by populating plan 1 TP list first. #17790

merged 1 commit into from
Mar 17, 2017

Conversation

matz-e
Copy link
Contributor

@matz-e matz-e commented Mar 6, 2017

Backport of #17789.

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Mar 6, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_9_0_X.

It involves the following packages:

CalibCalorimetry/CaloTPG

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@matz-e matz-e changed the title Fix compression LUTs by populating plan 1 TP list first. Fix HCAL TP compression LUTs by populating plan 1 TP list first. Mar 6, 2017
@franzoni
Copy link

franzoni commented Mar 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18185/console Started: 2017/03/07 06:39

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

-1

Tested at: 85afb83

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17790/18185/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-06-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Tue Mar 7 07:40:48 2017-date Tue Mar 7 07:39:41 2017 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Tue Mar 7 07:43:30 2017-date Tue Mar 7 07:40:24 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-06-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Mar 7 07:43:30 2017-date Tue Mar 7 07:40:24 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Tue Mar 7 07:43:30 2017-date Tue Mar 7 07:40:24 2017 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Tue Mar 7 07:44:32 2017-date Tue Mar 7 07:40:55 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-06-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Mar 7 07:44:32 2017-date Tue Mar 7 07:40:55 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Tue Mar 7 07:44:32 2017-date Tue Mar 7 07:40:55 2017 s - exit: 21504

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17790/18185/summary.html

@franzoni
Copy link

franzoni commented Mar 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18208/console Started: 2017/03/07 14:29

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

+1
Tested at: 85afb83
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17790/18208/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17790/18208/summary.html

franzoni
franzoni reviewed Mar 14, 2017
View reviewed changes
CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc
continue;
for (const auto& tower: theTrigTowerGeometry.towerIds(cell))
plan1_towers_.emplace(tower);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @matz-e
plan1_towers_
is filled only at this line, inside CaloTPGTranscoderULUT::getOutputLUTSize(...),
and loadHCALCompress() does not seem to affect its content.

Therefore,
why does the swapping the ordering matter ?

Copy link
Contributor Author

@matz-e matz-e Mar 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loadHCALCompress() calls getOutputLUTSize() in line 74, and thus relies on plan1_towers already filled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getOutputLUTSize() uses plan1_towers_ in line 212, that's why the order matters…

@franzoni
Copy link

+1

@deguio
Copy link
Contributor

deguio commented Mar 17, 2017

@rekovic
this is needed in 900. could you sign please?
thanks!
F.

@davidlange6
Copy link
Contributor

thanks for the reminder @deguio - will merge

@davidlange6 davidlange6 merged commit 8735b6d into cms-sw:CMSSW_9_0_X Mar 17, 2017
@davidlange6 davidlange6 mentioned this pull request Mar 24, 2017
Closed
@matz-e matz-e deleted the hcal-fix-compression-lut-90x branch September 15, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzoni franzoni franzoni left review comments

Assignees
No one assigned
Labels
alca-approved comparison-available l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@matz-e @cmsbuild @franzoni @deguio @davidlange6