Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding Phase1 timing client with tracking #18529

Merged
merged 2 commits into from
May 5, 2017
Merged

adding Phase1 timing client with tracking #18529

merged 2 commits into from
May 5, 2017

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented May 1, 2017

This PR adds an Online client with track reconstruction to perform Pixel timing in collisions

Also few minor things are modified:

  1. initialized a bool
  2. changed the ranges of residuals plots to be more useful with suboptimal alignment

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone May 1, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2017 •
edited by smuzaffar
Loading

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

DQM/Integration
DQM/SiPixelPhase1Config
DQM/SiPixelPhase1Digis
DQM/SiPixelPhase1TrackResiduals

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @batinkov, @hdelanno this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19508/console Started: 2017/05/02 14:32

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

+1
Tested at: e237c99
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18529/19508/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18529/19508/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1677 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831595
  • DQMHistoTests: Total failures: 26016
  • DQMHistoTests: Total nulls: 312
  • DQMHistoTests: Total successes: 1805087
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

davidlange6
davidlange6 reviewed May 4, 2017
View reviewed changes
DQM/SiPixelPhase1Config/python/SiPixelPhase1OnlineDQM_Timing_cff.py Outdated

# Pixel Digi Monitoring
from DQM.SiPixelPhase1Digis.SiPixelPhase1Digis_cfi import *
SiPixelPhase1DigisAnalyzer.src = cms.InputTag("siPixelDigis") # adapt for real data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fioriNTU - this does not need to be here (as it does not change anything - if it did, then you would need to clone the module) - please remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks for noticing, I will fix

davidlange6
davidlange6 reviewed May 4, 2017
View reviewed changes
DQM/SiPixelPhase1Config/python/SiPixelPhase1OnlineDQM_Timing_cff.py
#from DQM.SiPixelPhase1Summary.SiPixelPhase1Summary_cfi import *


siPixelPhase1OnlineDQM_source = cms.Sequence(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great if this implementation was shared with the offline cff... (its mostly a duplication)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep this completely independent by the Offline config. This piece is only used in the timing client, if someone mess it up will be transparent to the Offline

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Pull request #18529 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@fioriNTU
Copy link
Contributor Author

fioriNTU commented May 4, 2017

@davidlange6 you made me spot also a trivial error, I have set the geometry back to Phase 1 also, thanks.

@smuzaffar smuzaffar modified the milestones: CMSSW_9_2_X, CMSSW_9_1_X May 4, 2017
@fioriNTU
Copy link
Contributor Author

fioriNTU commented May 5, 2017

@davidlange this is not going to be integrated in 91X?

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19593/console Started: 2017/05/05 11:55

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

+1
Tested at: efdfdc0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18529/19593/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18529/19593/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3339 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 47136
  • DQMHistoTests: Total nulls: 312
  • DQMHistoTests: Total successes: 1783456
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

davidlange6
davidlange6 reviewed May 5, 2017
View reviewed changes
DQM/SiPixelPhase1Config/python/SiPixelPhase1OnlineDQM_Timing_cff.py Outdated
@@ -82,8 +82,8 @@
#

# To Configure Phase1 DQM for Phase0 data
SiPixelPhase1Geometry.upgradePhase = 0
SiPixelPhase1Geometry.onlineblock = 5
SiPixelPhase1Geometry.upgradePhase = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuck...
lets remove this sort of flag in favor of geometry driven code..

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9e4fba4 into cms-sw:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlange6 davidlange6 davidlange6 left review comments

Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.
5 participants
@fioriNTU @cmsbuild @dmitrijus @davidlange6 @smuzaffar