Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GE11 geometry customs #2213

Merged
merged 2 commits into from
Jan 29, 2014
Merged

GE11 geometry customs #2213

merged 2 commits into from
Jan 29, 2014

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Jan 29, 2014

Python configuration to customise GE1/1 with cmsDriver.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_6_2_X_SLHC.

GE11 geometry customs

It involves the following packages:

Geometry/GEMGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Jan 29, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

Didn't actually run any tests, but looking at the files changed only one file is added that isn't referenced anywhere else yet. None of my current set of matrix tests will test these changes. I could try a "--customise" with one of these new configurations but I don't think that'll prove much.

cmsbuild added a commit that referenced this pull request Jan 29, 2014
@cmsbuild cmsbuild merged commit 86e4e97 into cms-sw:CMSSW_6_2_X_SLHC Jan 29, 2014
@dildick
Copy link
Contributor Author

dildick commented Jan 29, 2014

Thanks Mark.

On 01/29/2014 08:18 AM, cmsbuild wrote:

Merged #2213 #2213.


Reply to this email directly or view it on GitHub
#2213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants