update FastSim recycling strings for 9_4_X

[zhenhu]

Solve the 9_4_X IB failures reported in issue #25104

[cmsbuild]

A new Pull Request was created by @zhenhu (Zhen Hu) for CMSSW_9_4_X.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[zhenhu]

please test workflow 25402.0,250399.0,250402,25402.17,250399.17,250402.17

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31477/console Started: 2018/11/05 20:24

[cmsbuild]

+1
Tested at: e29ff6a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25123/31477/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25123/31477/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25123/250399.0_FS_PREMIXUP15_PU25+FS_PREMIXUP15_PU25
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25123/250399.17_FS_PREMIXUP17_PU50+FS_PREMIXUP17_PU50
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25123/250402.0_TTbar_13+FS_TTbar_13_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25123/250402.17_TTbar_13+FS_TTbar_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25123/25402.0_TTbar_13+FS_TTbar_13_UP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25123/25402.17_TTbar_13+FS_TTbar_13_UP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 104
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721227
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[zhenhu]

+1

[prebello]

@zhenhu I was checking the 9_4_X FastSim strings. As a matter of padronization, maybe you want to change their "baseDataSetRelease" numbers to # 17 and # 18, to be coherent with master? # 15 and # 16 are dedicated to 2018 FullSim premix strings in master, and could cause confusion.
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py

[zhenhu]

Hi @prebello , good point, but maybe it's better to change the master.
I mean, swap # 15 # 16 with # 17 # 18 in the master.

[prebello]

yes @zhenhu, it could be. I will make a PR.

[fabiocos]

@zhenhu @prebello sorry I am not sure to follow your discussion: aren't these versions part of the existing dataset name already? And where are exactly these v17 and v18 present in master? I am unable to catch them...

Anyway, do you confirm this PR is ok as it is?

[prebello]

Hi @fabiocos
the difference between master and 94X is from line 621 to 624 (FullSim and FastSim strings)
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L621

This PR is ok. I will change the numbers (swap FullSim and FastSim) in master instead (easiest procedure)

[fabiocos]

@prebello ah now I see what you mean, #15 is the position in the fragment list, sorry, I confused with the accidentally similar version in the dataset name

[fabiocos]

+1

[fabiocos]

merge

@kpedro88 nothing really relevant for upgrade, in case please sign for reference

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will be automatically merged.