Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two more root6 relval fixes #2682

Merged
merged 3 commits into from
Mar 1, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 28, 2014

This is a fix for two ROOT6 specific bugs causing relval failures.

  1. TypeWithDict::typeOf() is used to strip off array and pointer information to get the underlying type.
    It was written returning a dummy type if the original type is not an array or pointer. This is not in itself a bug, because the analogous Reflex function did the same. However,the conditions code as written for ROOT6 assumes that the original type will be returned if the type is not an array or a pointer. The easiest way to fix this for now is to have toType() return the original type.
  2. The conditions code assumed incorrectly that TypeWithDict::size() returns the number of elements in the array if the type is an array. It does not. The correct function to call is TypeWithDict::arrayLength().
    This pull request changes the call to use arrayLength().
    Please merge this promptly unless there are problems.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Two more root6 relval fixes

It involves the following packages:

CondCore/ORA
FWCore/Utilities

@apfeiffer1, @Dr15Jones, @cmsbuild, @nclopezo, @ggovi, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request Mar 1, 2014
ROOT6 -- Two more root6 relval fixes
@ktf ktf merged commit 6ad8361 into cms-sw:CMSSW_7_1_ROOT6_X Mar 1, 2014
@wmtan wmtan deleted the TwoMoreROOT6RelvalFixes branch March 5, 2014 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants