Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed PTStatisitcs class static to const #2776

Merged
merged 1 commit into from
Mar 11, 2014

Conversation

Dr15Jones
Copy link
Contributor

By initializing the class static at load time, it was possible to
make the static const and therefore avoid thread-safety issues.

By initializing the class static at load time, it was possible to
make the static const and therefore avoid thread-safety issues.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Changed PTStatisitcs class static to const

It involves the following packages:

Validation/MuonRPCGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Mar 11, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 11, 2014
Validation/MuonRPCGeometry -- Changed PTStatisitcs class static to const
@nclopezo nclopezo merged commit 3dfa2f1 into cms-sw:CMSSW_7_1_X Mar 11, 2014
@Dr15Jones Dr15Jones deleted the makePTStatisticsThreadSafe branch March 17, 2014 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants