-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the TEC mod from Adrian Perieanu to the test2014 folder #2794
Adding the TEC mod from Adrian Perieanu to the test2014 folder #2794
Conversation
A new Pull Request was created by @GiacomoSguazzoni for CMSSW_7_1_X. Adding the TEC mod from Adrian Perieanu to the test2014 folder It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks. |
@@ -894,7 +894,7 @@ | |||
<rMaterial name="trackermaterial:T_CarbonFibreStr" /> | |||
</MaterialFraction> | |||
</CompositeMaterial> | |||
<CompositeMaterial name="TEC_PatchpanelBox" density="2.669*g/cm3" method="mixture by weight" symbol=" "> | |||
<CompositeMaterial density="2.669*0.79*g/cm3" method="mixture by weight" name="TEC_PatchpanelBox" symbol=" "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GiacomoSguazzoni - I think, keeping the attribute order is important.
I would also agree that there is no sense to change order of parameters, because this introduces extra mess. It may be that xml parser resolve the situation and can read these lines but these files are less readable, so it is not good for maintenance. |
+1 |
Geometry -- Adding the TEC mod from Adrian Perieanu to the test2014 folder
No description provided.