Modernized XMLIdealGeometryESProducer

[Dr15Jones]

PR description:

• specify consumes and use ESGetToken
• added fillDescriptions

PR validation:

runTheMatrix.py tests work fine.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28215/12333

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

GeometryReaders/XMLIdealGeometryESSource

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3029/console Started: 2019/10/18 21:47

[cmsbuild]

+1
Tested at: 715c7e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1bb8/3029/summary.html

[cmsbuild]

Comparison job queued.

[ianna]

@cvuosalo - please, check if the following tests run fine:
https://cmssdt.cern.ch/lxr/search?%21v=CMSSW_11_0_X_2019-10-16-2300&_filestring=py&_string=XMLIdealGeometryESProducer

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1bb8/3029/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960721
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #28223,#28216,#28217,#28218
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3056/console Started: 2019/10/21 16:18

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3067/console Started: 2019/10/21 21:43

[cmsbuild]

+1
Tested at: 715c7e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1bb8/3067/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1bb8/3067/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960722
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[cvuosalo]

Test configs that include the code revised in this PR seem to run the same as they do in the baseline. Two configs were tested:
GeometryReaders/XMLIdealGeometryESSource/test/testReadXMLFromGTDB.py
SimTracker/TrackerMaterialAnalysis/test/listIds_PhaseII.py

[Dr15Jones]

Please review this pull request. It is needed for waiting framework changes.

[ianna]

@Dr15Jones - proposed changes look good to me.

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1