Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Shashlik Geometry #2892

Merged
merged 14 commits into from
Mar 24, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Mar 17, 2014

  • Close gaps between supermodules
  • Remove overlaps/extrusions
  • Extract pointing location to be defined in xml

@ianna
Copy link
Contributor Author

ianna commented Mar 17, 2014

+1

@ianna ianna mentioned this pull request Mar 17, 2014
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@andersonjacob
Copy link
Contributor

There are many printouts like this

Shashlik SM 1192: xphi=0.246696 yphi=-0.061674 offsets = (1428.74, -323.658, 3257.23)
 copyNo = 1193 (20,20): offsetX,Y = 1428.74,-395.783 limit=1482.54 rMin, rMax=387,1469
 copyNo = 1193 (20,20): offsetX,Y = 1428.74,-468.029 limit=1503.44 rMin, rMax=387,1469
 copyNo = 1193 (20,20): offsetX,Y = 1428.74,-540.419 limit=1527.53 rMin, rMax=387,1469
...

then I get failure in step1 from the matrix 12400 of

----- Begin Fatal Exception 17-Mar-2014 18:09:56 CET-----------------------
An exception of category 'InvalidDetId' occurred while
   [0] Processing run: 1 lumi: 1 event: 5
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarProducer/'g4SimHits'
Exception Message:
EKDetId::ix() called with wrong arguments SM/Module 1086:7
----- End Fatal Exception -------------------------------------------------

12600 fails similarly in step1

----- Begin Fatal Exception 17-Mar-2014 18:11:05 CET-----------------------
An exception of category 'InvalidDetId' occurred while
   [0] Processing run: 1 lumi: 1 event: 5
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarProducer/'g4SimHits'
Exception Message:
EKDetId::ix() called with wrong arguments SM/Module 1104:9
----- End Fatal Exception -------------------------------------------------

@ianna
Copy link
Contributor Author

ianna commented Mar 19, 2014

@andersonjacob - this geometry will require an update for DetId. We've discussed it with @bsunanda - he will provide a fix for it.

@mark-grimes mark-grimes mentioned this pull request Mar 24, 2014
@mark-grimes
Copy link

Tested with #2892 (EDIT - #2976. This is 2892) and #2990, see the comments on #2990. Waiting for signature on #2990 then I'll merge all three requests.

@mark-grimes mark-grimes mentioned this pull request Mar 24, 2014
@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Mar 24, 2014
@cmsbuild cmsbuild merged commit 1f18920 into cms-sw:CMSSW_6_2_X_SLHC Mar 24, 2014
@mark-grimes mark-grimes mentioned this pull request Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants