Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct GE21 station rotation #2951

Merged
merged 4 commits into from
Mar 24, 2014
Merged

Correct GE21 station rotation #2951

merged 4 commits into from
Mar 24, 2014

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Mar 20, 2014

This branch is built on top of #2944. Please use this one.

  • Rotate GE21 in + endcap by 5 degrees
  • Rotate GE21 in - endcap by -5 degrees

@dildick dildick changed the title Correct ge21 station rotation Correct GE21 station rotation Mar 20, 2014
@dildick
Copy link
Contributor Author

dildick commented Mar 21, 2014

Did @cmsbuild miss this PR?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_6_2_X_SLHC.

Correct GE21 station rotation

It involves the following packages:

Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

Tested on top of #2944, although it appears to overwrite those changes.
Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.
I will merge when we have a signature from Geometry. @ianna would you prefer this or #2944 accepted?

@dildick
Copy link
Contributor Author

dildick commented Mar 24, 2014

It only overwrites the rotation for the negative endcap.

@ianna
Copy link
Contributor

ianna commented Mar 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

@mark-grimes
Copy link

merge

Try again. cmsbuild seems to be ignoring me, maybe I need to have a comment afterwards.

cmsbuild added a commit that referenced this pull request Mar 24, 2014
@cmsbuild cmsbuild merged commit 648e161 into cms-sw:CMSSW_6_2_X_SLHC Mar 24, 2014
@dildick dildick deleted the Correct-GE21-station-rotation branch April 8, 2014 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants