-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROOT master] Add direct deps after ROOT cleanup #29740
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29740/15144
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
f289e29
to
41a9dfb
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29740/15147
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: Alignment/OfflineValidation @perrotta, @smuzaffar, @andrius-k, @Dr15Jones, @alja, @makortel, @schneiml, @tlampen, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @slava77, @tocheng, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The tests are being triggered in jenkins. |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+core |
@silviodonato , can we get this in? It is just a technical update to explicitly add the includes which are cleaned up in root master. This is blocking the integration of root master. |
+1
|
merge |
PR description:
Adds direct dependencies for used types namely TObjString, TFile and std::set
See: cms-sw/cmsdist#5800 and https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370a62/5988/build-logs/
We had the types present included indirectly by other headers (I'd guess)
I didn't want to open 10 PRs with one line change, hence the multiple categories
PR validation:
Builds with ROOT_X IB (given we have the GL installed, I copied it by hand for the test, it built)