Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers path for new Pythia 8.183. #2991

Merged
1 commit merged into from Mar 24, 2014
Merged

Fix headers path for new Pythia 8.183. #2991

1 commit merged into from Mar 24, 2014

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2014

Following integration of #2829 FastSimulation/ParticleDecay was broken due to headers pointing the wrong path.

Following integration of #2829 FastSimulation/ParticleDecay was broken due to headers pointing the wrong path.
@ghost ghost added fastsim-pending labels Mar 24, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Degano (Alessandro Degano) for CMSSW_6_2_X.

Fix headers path for new Pythia 8.183.

It involves the following packages:

FastSimulation/ParticleDecay

@cmsbuild, @Degano, @giamman, @lveldere, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ghost
Copy link
Author

ghost commented Mar 24, 2014

@lveldere @giamman @davidlange6
Latest release is due for today, can you please review and eventually sign?

@lveldere
Copy link
Contributor

+1

@ghost ghost added fastsim-approved labels Mar 24, 2014
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 24-Mar-2014 10:14:15 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'FamosProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log
----- Begin Fatal Exception 24-Mar-2014 10:14:24 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'FamosProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log
----- Begin Fatal Exception 24-Mar-2014 10:17:53 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'FamosProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2991/57/summary.html

@ghost ghost added fastsim-approved labels Mar 24, 2014
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (but tests are reportedly failing). @Degano can you please take care of it?

@ghost
Copy link
Author

ghost commented Mar 24, 2014

+1
Tested locally. The reason it failed the automatic testing is that checkdeps didn't take in FastSimulation/EventProducer which also need to be recompiled. This is known feature of checkdeps.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (tests are also fine). @Degano can you please take care of it?

@ghost ghost added fastsim-approved labels Mar 24, 2014
@ktf
Copy link
Contributor

ktf commented Mar 24, 2014

Given IBs are broken, please go ahead an merge this.

ghost pushed a commit that referenced this pull request Mar 24, 2014
…ders

Fix Generators -- Fix headers path for new Pythia 8.183.
@ghost ghost merged commit 1f3752b into cms-sw:CMSSW_6_2_X Mar 24, 2014
@ghost ghost deleted the 62X_fastsim_particledecay_fixHeaders branch May 15, 2014 14:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants