Implementing ESGetToken in L1-O2O producers in 112X #30155

gekobs · 2020-06-08T20:28:32Z

PR description:

Since CMSSW_11_0_X which incorporates PR#28223 all classes inheriting from ESProducer need to use ESGetToken to access data from EventSetup.
This PR updates both L1T O2O base producers (CondTools/L1TriggerExt) and L1T subsystems producers (L1TriggerConfig/L1TConfigProducers) to use ESGetToken.
As l1t-o2o fails since CMSSW_11_0_X a backport will be implemented.

PR validation:

The code has been tested running the runTheMatrix workflows, code-checks and code-format. Moreover a test running a complete l1t o2o worflow has been done in local.

cmsbuild · 2020-06-08T20:28:55Z

@gekobs, CMSSW_11_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2020-06-08T20:29:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-08T20:35:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30155/15942

This PR adds an extra 904KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CondTools/L1TriggerExt/plugins/L1CondDBPayloadWriterExt.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File CondTools/L1TriggerExt/plugins/L1TriggerKeyOnlineProdExt.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File L1TriggerConfig/L1TConfigProducers/src/L1TCaloParamsOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-faster-string-find #29926, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File L1TriggerConfig/L1TConfigProducers/src/L1TMuonBarrelParamsOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File L1TriggerConfig/L1TConfigProducers/src/L1TMuonEndCapParamsOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File L1TriggerConfig/L1TConfigProducers/src/L1TMuonGlobalParamsOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File L1TriggerConfig/L1TConfigProducers/src/L1TUtmTriggerMenuOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-08T20:36:28Z

A new Pull Request was created by @gekobs (agzecchinelli) for master.

It involves the following packages:

CondTools/L1TriggerExt
HLTrigger/Configuration
L1TriggerConfig/L1TConfigProducers

@Martin-Grunewald, @benkrikler, @cmsbuild, @rekovic, @fwyzard, @ggovi can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

…vent data

cmsbuild · 2020-06-08T21:36:23Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-08T21:41:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30155/15944

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CondTools/L1TriggerExt/plugins/L1CondDBPayloadWriterExt.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File CondTools/L1TriggerExt/plugins/L1TriggerKeyOnlineProdExt.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File L1TriggerConfig/L1TConfigProducers/src/L1TCaloParamsOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-faster-string-find #29926, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File L1TriggerConfig/L1TConfigProducers/src/L1TMuonBarrelParamsOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File L1TriggerConfig/L1TConfigProducers/src/L1TMuonEndCapParamsOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File L1TriggerConfig/L1TConfigProducers/src/L1TMuonGlobalParamsOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File L1TriggerConfig/L1TConfigProducers/src/L1TUtmTriggerMenuOnlineProd.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-18T02:11:09Z

Pull request #30155 was updated. @ggovi, @rekovic, @benkrikler, @cmsbuild can you please check and sign again.

silviodonato · 2020-06-22T16:07:47Z

please test

cmsbuild · 2020-06-22T16:08:07Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-22-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7252/console Started: 2020/06/22 18:13

silviodonato · 2020-06-22T16:10:27Z

Do you have any comments @rekovic @ggovi ?
I think @makortel 's comments have been addressed.

cmsbuild · 2020-06-22T17:28:07Z

+1
Tested at: 405f208
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fbfea/7252/summary.html
CMSSW: CMSSW_11_2_X_2020-06-22-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-22T17:28:10Z

Comparison job queued.

cmsbuild · 2020-06-22T19:27:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fbfea/7252/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778760
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

ggovi · 2020-06-23T11:36:32Z

+1

rekovic · 2020-06-30T14:18:22Z

+1

cmsbuild · 2020-06-30T14:18:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

rekovic · 2020-06-30T14:52:14Z

@gekobs
Please make a back-port PR to 11_1_X.

silviodonato · 2020-06-30T19:15:02Z

+1

boudoul · 2020-07-01T05:15:00Z

@gekobs
Please make a back-port PR to 11_1_X.

Dear @gekobs , did you make the backport ? If not please do it as soon as possible - Thank you

cmsbuild changed the base branch from CMSSW_11_2_X to master June 8, 2020 20:28

cmsbuild added this to the CMSSW_11_2_X milestone Jun 8, 2020

cmsbuild added code-checks-pending comparison-pending db-pending hlt-pending l1-pending orp-pending pending-signatures tests-pending labels Jun 8, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 8, 2020

gekobs added 6 commits June 8, 2020 23:25

updating O2O producers, from getByLabel to getByToken for accessing e…

8015235

…vent data

Use ESGetToken in L1T-O2O producers

8fac53e

Using ESGetToken in L1T-O2O producers

58cf259

Using ESGetToken in L1T-O2O producers

766f1d9

applying code-checks

2ef7004

minor code cleaning

bc574b0

gekobs force-pushed the ESGetTokenUpdate branch from e872aa3 to bc574b0 Compare June 8, 2020 21:35

cmsbuild added code-checks-pending and removed code-checks-approved hlt-pending labels Jun 8, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 8, 2020

cmsbuild added the code-checks-approved label Jun 18, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 22, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 22, 2020

cmsbuild added db-approved and removed db-pending labels Jun 23, 2020

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jun 30, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 30, 2020

cmsbuild merged commit 3401c8e into cms-sw:master Jun 30, 2020

gekobs mentioned this pull request Jul 1, 2020

Backport to 111X of ESGetToken update in L1T O2O producer #30494

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing ESGetToken in L1-O2O producers in 112X #30155

Implementing ESGetToken in L1-O2O producers in 112X #30155

gekobs commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 18, 2020

silviodonato commented Jun 22, 2020

cmsbuild commented Jun 22, 2020 •

edited

Loading

silviodonato commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

ggovi commented Jun 23, 2020

rekovic commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

rekovic commented Jun 30, 2020 •

edited by silviodonato

Loading

silviodonato commented Jun 30, 2020

boudoul commented Jul 1, 2020 •

edited

Loading

Implementing ESGetToken in L1-O2O producers in 112X #30155

Implementing ESGetToken in L1-O2O producers in 112X #30155

Conversation

gekobs commented Jun 8, 2020

PR description:

PR validation:

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 8, 2020

cmsbuild commented Jun 18, 2020

silviodonato commented Jun 22, 2020

cmsbuild commented Jun 22, 2020 • edited Loading

silviodonato commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

cmsbuild commented Jun 22, 2020

ggovi commented Jun 23, 2020

rekovic commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

rekovic commented Jun 30, 2020 • edited by silviodonato Loading

silviodonato commented Jun 30, 2020

boudoul commented Jul 1, 2020 • edited Loading

cmsbuild commented Jun 22, 2020 •

edited

Loading

rekovic commented Jun 30, 2020 •

edited by silviodonato

Loading

boudoul commented Jul 1, 2020 •

edited

Loading