Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clang tidy] Apply checks for geometry-upgrade #30799

Merged
merged 2 commits into from
Jul 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Geometry/HGCalGeometry/src/HGCalMouseBite.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ HGCalMouseBite::HGCalMouseBite(const HGCalDDDConstants& hgc, const bool rot) {
if (modeUV) {
const std::vector<double> angle = {90._deg, 30._deg};
std::vector<std::pair<double, double> > projXY;
projXY.reserve(angle.size());
for (auto ang : angle)
projXY.emplace_back(std::make_pair(cos(ang), sin(ang)));
const double mousebite(hgc.mouseBite(true));
Expand Down
2 changes: 1 addition & 1 deletion Geometry/MTDCommonData/src/BTLNumberingScheme.cc
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ uint32_t BTLNumberingScheme::getUnitID(const MTDBaseNumber& baseNumber) const {
uint32_t pos = modName.find("Positive");

const uint32_t zside = (pos <= strlen(modName.c_str()) ? 1 : 0);
std::string baseName = modName.substr(modName.find(":") + 1);
std::string baseName = modName.substr(modName.find(':') + 1);

// trick to accomodate both 54, 42 and 48 modules designs
const int modtyp(
Expand Down
2 changes: 1 addition & 1 deletion Geometry/MTDCommonData/src/ETLNumberingScheme.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ uint32_t ETLNumberingScheme::getUnitID(const MTDBaseNumber& baseNumber) const {

const std::string& ringName(baseNumber.getLevelName(3)); // name of ring volume
int modtyp(0);
std::string baseName = ringName.substr(ringName.find(":") + 1);
std::string baseName = ringName.substr(ringName.find(':') + 1);
int ringCopy(::atoi(baseName.c_str() + 4));

uint32_t discN, sectorS, sectorN;
Expand Down
2 changes: 1 addition & 1 deletion Geometry/MTDGeometryBuilder/src/MTDGeometry.cc
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ bool MTDGeometry::isThere(GeomDetEnumerators::SubDetector subdet) const {

void MTDGeometry::fillTestMap(const GeometricTimingDet* gd) {
const std::string& temp = gd->name();
std::string name = temp.substr(temp.find(":") + 1);
std::string name = temp.substr(temp.find(':') + 1);
DetId detid = gd->geographicalId();
float thickness = gd->bounds()->thickness();
std::string nameTag;
Expand Down