-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MillePede alignment: add resubmission option #31049
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31049/17556
|
A new Pull Request was created by @adewit for master. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@cmsbuild ping? |
please test |
The tests are being triggered in jenkins.
|
-1 Tested at: 37b394f CMSSW: CMSSW_11_2_X_2020-08-06-1100 I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Thu Aug 6 18:03:24 2020-date Thu Aug 6 17:57:39 2020 s - exit: 35584 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Can't really see how this could cause a segfault in addOn tests for fastsim, see link |
@cmsbuild, please test Let's see if the pattern repeats |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This adds an option for millepede alignment job resubmission (removing various files from the output directory that otherwise do not get overwritten correctly when trying to resubmit the jobs). @connorpa @vbotta FYI.
PR validation:
Has been tested to produce the desired behaviour in the alignment workflow.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport