-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix es consumes in dd4hep/TrackerParametersESProducer #31226
fix es consumes in dd4hep/TrackerParametersESProducer #31226
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31226/17887
|
@cmsbuild, please test |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Geometry/TrackerGeometryBuilder @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@cvuosalo urgent ;) |
urgent |
Geometry/TrackerGeometryBuilder/plugins/dd4hep/TrackerParametersESProducer.cc
Outdated
Show resolved
Hide resolved
Geometry/TrackerGeometryBuilder/plugins/dd4hep/TrackerParametersESProducer.cc
Outdated
Show resolved
Hide resolved
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31226/17896
|
Pull request #31226 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Addresses #27926 (comment).
Added ES consumes as done for
Geometry/TrackerGeometryBuilder/plugins/TrackerParametersESModule.cc
in #28228PR validation:
It compiles. Cannot be tested further because of #27926 (comment)
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport needed