Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isLocal and use location() #3132

Merged

Conversation

jpavel
Copy link
Contributor

@jpavel jpavel commented Apr 1, 2014

Fix requested by @davidlange6 at #3059.

@jpavel jpavel mentioned this pull request Apr 1, 2014
@jpavel
Copy link
Contributor Author

jpavel commented Apr 1, 2014

@monicava, this is something you wanted to watch

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2014

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_6_2_X_SLHC.

Remove isLocal and use location()

It involves the following packages:

RecoTauTag/RecoTau

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

Tested by removing wpDiscriminationAgainstElectronMVA5.root from the checked out package in $CMSSW_BASE so that it has to look for the one in $CMSSW_RELEASE_BASE. First verified that step 3 crashes, then applied the patch.
Fixes these tests which failed step 3 in the Integration Build: 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000. Tried other tests but ran of disk quota.

cmsbuild added a commit that referenced this pull request Apr 1, 2014
@cmsbuild cmsbuild merged commit 2dfe0ba into cms-sw:CMSSW_6_2_X_SLHC Apr 1, 2014
@jpavel jpavel deleted the taus_6_2_X_SLHC_isLocalFix branch April 1, 2014 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants