esConsumes migration for SiStripFedZeroSuppression, SiStripHitEffFromCalibTree, and SiStripClusterToDigiProducer

[pieterdavid]

PR description:

esConsumes migration #31061 for modules in SiStrip packages not covered in #31826 and #32677 (I left SiStripFedZeroSuppression for after #31697, and apparently overlooked SiStripHitEffFromCalibTree and SiStripClusterToDigiProducer previously).

PR validation:

The limited set of matrix tests ran without errors

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33632/22496

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiStripZeroSuppression/interface/SiStripFedZeroSuppression.h modified in PR(s): update deepCore for Run3 #33531
  • File RecoLocalTracker/SiStripZeroSuppression/src/SiStripFedZeroSuppression.cc modified in PR(s): update deepCore for Run3 #33531
  • File SimTracker/SiStripDigitizer/plugins/DigiSimLinkAlgorithm.cc modified in PR(s): update deepCore for Run3 #33531
  • File SimTracker/SiStripDigitizer/plugins/PreMixingSiStripWorker.cc modified in PR(s): update deepCore for Run3 #33531
  • File SimTracker/SiStripDigitizer/plugins/SiStripDigitizerAlgorithm.cc modified in PR(s): update deepCore for Run3 #33531

[cmsbuild]

A new Pull Request was created by @pieterdavid (Pieter David) for master.

It involves the following packages:

CalibTracker/SiStripHitEfficiency
RecoLocalTracker/SiStripClusterizer
RecoLocalTracker/SiStripZeroSuppression
SimTracker/SiStripDigitizer

@perrotta, @malbouis, @civanch, @yuanchao, @tlampen, @mdhildreth, @cmsbuild, @slava77, @jpata, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @gbenelli, @makortel, @robervalwalsh, @yduhm, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @alesaggio, @prolay, @tocheng, @felicepantaleo, @mtosi, @gpetruc, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa3301/14878/summary.html
COMMIT: 23498b4
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33632/14878/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33632/22498

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiStripZeroSuppression/interface/SiStripFedZeroSuppression.h modified in PR(s): update deepCore for Run3 #33531
  • File RecoLocalTracker/SiStripZeroSuppression/src/SiStripFedZeroSuppression.cc modified in PR(s): update deepCore for Run3 #33531
  • File SimTracker/SiStripDigitizer/plugins/DigiSimLinkAlgorithm.cc modified in PR(s): update deepCore for Run3 #33531
  • File SimTracker/SiStripDigitizer/plugins/PreMixingSiStripWorker.cc modified in PR(s): update deepCore for Run3 #33531
  • File SimTracker/SiStripDigitizer/plugins/SiStripDigitizerAlgorithm.cc modified in PR(s): update deepCore for Run3 #33531

[cmsbuild]

Pull request #33632 was updated. @perrotta, @malbouis, @civanch, @yuanchao, @tlampen, @mdhildreth, @cmsbuild, @slava77, @jpata, @pohsun, @francescobrivio can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33632/22559

• This PR adds an extra 56KB to repository

[cmsbuild]

Pull request #33632 was updated. @perrotta, @malbouis, @civanch, @yuanchao, @tlampen, @mdhildreth, @cmsbuild, @slava77, @jpata, @pohsun, @francescobrivio can you please check and sign again.

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa3301/14949/summary.html
COMMIT: 8e03b84
CMSSW: CMSSW_12_0_X_2021-05-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33632/14949/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2663174
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2663151
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[perrotta]

+1

• Technical
• Jenkins tests pass

[qliphy]

alca already signed before the last simple fix on member name.

[qliphy]

+1

[qliphy]

merge