Add init values for struct members to silence Arm warning

[mrodozov]

PR description:

Initializes struct members to some default. Not being init they cause a warning in Arm builds:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_aarch64_gcc9/CMSSW_12_0_X_2021-05-14-1100/L1Trigger/L1TTrackMatch

PR validation:

The warning is gone after the change (checked on Arm)

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33742/22688

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

L1Trigger/L1TTrackMatch

@rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5baba2/15113/summary.html
COMMIT: 5665a2c
CMSSW: CMSSW_12_0_X_2021-05-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33742/15113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648213
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[mrodozov]

please test for slc7_aarch64_gcc9

[VinInn]

I do not agree with this kind of very conservative approach.
"may be used uninitialized" is a weird warning. if ASAN is happy do not see why we should initialize variables if not needed.
It may be costly (and in principle makes the struct NOT a POD anymore).
We should instead do the opposite: actively remove all initializations and copies that are not required by algorithms.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5baba2/15118/summary.html
COMMIT: 5665a2c
CMSSW: CMSSW_12_0_X_2021-05-14-2300/slc7_aarch64_gcc9
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33742/15118/install.sh to create a dev area with all the needed externals and cmssw changes.

[mrodozov]

I'll keep the members as they were, but to get rid of that warning I consider:

1. removing this lines
   https://github.com/mrodozov/cmssw/blob/5665a2cdcf6d375ce0390c85b83fb4c37607eb71/L1Trigger/L1TTrackMatch/plugins/L1TrackJetProducer.cc#L277-L279
   leaving the array elements uninitialized (as they currently are because they are assigned another uninit object)

2. init the object in place to:
   MaxZBin mzbtemp = {0, 0, 0, nullprt, 0};

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33742/22690

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #33742 was updated. @cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please check and sign again.

[mrodozov]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5baba2/15120/summary.html
COMMIT: 5ee4b99
CMSSW: CMSSW_12_0_X_2021-05-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33742/15120/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5baba2/15120/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2648207
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[srimanob]

+Upgrade

Technical PR to fix ARM warning.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1