Run3-gex83A Make a few SD's in SimG4CMS/Forward with the new way of initiation #34507

bsunanda · 2021-07-15T19:08:47Z

PR description:

Make a few SD's in SimG4CMS/Forward with the new way of initiation

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-07-15T19:15:56Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34507/23996

This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34507/23996/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34507/23996/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-07-15T19:28:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34507/23997

This PR adds an extra 28KB to repository

cmsbuild · 2021-07-15T19:28:35Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

SimG4CMS/Forward (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-07-15T20:08:59Z

@cmsbuild Please test

cmsbuild · 2021-07-15T20:15:57Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21f0fb/16865/summary.html
COMMIT: de43f97
CMSSW: CMSSW_12_0_X_2021-07-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34507/16865/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-15-1100/src/SimG4CMS/Forward/src/ZdcSensitiveDetector.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-15-1100/src/SimG4CMS/Forward/src/ZdcSensitiveDetectorBuilder.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-15-1100/src/SimG4CMS/Forward/src/ZdcShowerLibrary.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-15-1100/src/SimG4CMS/Forward/src/ZdcTestAnalysis.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-15-1100/src/SimG4CMS/Forward/src/ZdcShowerLibrary.cc:7:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-15-1100/poison/SimG4CMS/Forward/interface/ZdcSD.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
>> Compiling bigobj /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-15-1100/src/SimG4CMS/Forward/src/BHMNumberingScheme.cc
>> Compiling bigobj /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-15-1100/src/SimG4CMS/Forward/src/BHMSD.cc
>> Compiling bigobj /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-15-1100/src/SimG4CMS/Forward/src/BSCG4Hit.cc

civanch · 2021-07-15T20:23:26Z

@bsunanda , it is not a good idea renaming these classes. Previous names were fine, what is bad in CastorSD?

civanch · 2021-07-15T20:25:59Z

@bsunanda , we need to complete migration of SD classes to the new design. Chris made this only for main par, there several SD classes to be migrated. We need to find all (used or not used and do this.

civanch · 2021-07-16T20:40:47Z

SimG4CMS/Forward/src/TotemSD.cc

@@ -42,11 +42,11 @@
 #include "G4PhysicalConstants.hh"
 #include "G4SystemOfUnits.hh"

+#define EDM_ML_DEBUG


@bsunanda , please, comment out DEBUG.

civanch · 2021-07-16T20:42:16Z

SimG4CMS/Forward/src/ZdcSD.cc

@@ -25,8 +25,9 @@
 #include "Randomize.hh"
 #include "G4Poisson.hh"

+#define EDM_ML_DEBUG


Here as well.

cmsbuild · 2021-07-16T21:26:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34507/24040

This PR adds an extra 20KB to repository
Found files with invalid states:
- SimG4CMS/Forward/src/TotemSensitiveDetector.cc:
  - Added: 8c9ab71
  - Deleted: 0190046
- SimG4CMS/Forward/src/TotemSensitiveDetectorBuilder.cc:
  - Added: 8c9ab71
  - Modified: de43f97, 0190046
  - Deleted: 25143e4
- SimG4CMS/Forward/interface/ZdcSD.h:
  - Deleted: 8c9ab71
  - Added: 0190046
  - Modified: 3464acf
- SimG4CMS/Forward/interface/CastorSensitiveDetector.h:
  - Added: 8c9ab71
  - Deleted: 0190046
- SimG4CMS/Forward/interface/TotemSD.h:
  - Deleted: 8c9ab71
  - Added: 0190046
  - Modified: 3464acf
- SimG4CMS/Forward/interface/TotemSensitiveDetector.h:
  - Added: 8c9ab71
  - Deleted: 0190046
- SimG4CMS/Forward/src/ZdcSensitiveDetector.cc:
  - Added: 8c9ab71
  - Deleted: 0190046
- SimG4CMS/Forward/src/CastorSensitiveDetector.cc:
  - Added: 8c9ab71
  - Deleted: 0190046
- SimG4CMS/Forward/src/ZdcSensitiveDetectorBuilder.cc:
  - Added: 8c9ab71
  - Modified: de43f97, 0190046
  - Deleted: 25143e4
- SimG4CMS/Forward/src/TotemSD.cc:
  - Deleted: 8c9ab71
  - Added: 0190046
  - Modified: 3464acf, 597185c
- SimG4CMS/Forward/src/ZdcSD.cc:
  - Deleted: 8c9ab71
  - Added: 0190046
  - Modified: 3464acf, 597185c
- SimG4CMS/Forward/interface/CastorSD.h:
  - Deleted: 8c9ab71
  - Added: 0190046
  - Modified: 3464acf
- SimG4CMS/Forward/src/CastorSensitiveDetectorBuilder.cc:
  - Added: 8c9ab71
  - Modified: de43f97, 0190046
  - Deleted: 25143e4
- SimG4CMS/Forward/src/CastorSD.cc:
  - Deleted: 8c9ab71
  - Added: 0190046
  - Modified: 3464acf
- SimG4CMS/Forward/interface/ZdcSensitiveDetector.h:
  - Added: 8c9ab71
  - Deleted: 0190046

cmsbuild · 2021-07-16T21:26:47Z

Pull request #34507 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

bsunanda · 2021-07-16T21:33:09Z

@cmsbuild Please test

cmsbuild · 2021-07-17T09:58:22Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21f0fb/16932/summary.html
COMMIT: 597185c
CMSSW: CMSSW_12_0_X_2021-07-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34507/16932/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2786302
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2786273
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

civanch · 2021-07-17T22:46:46Z

+1

cmsbuild · 2021-07-17T22:47:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-07-18T02:39:35Z

+1

Make a few SD's in SimG4CMS/Forward with the new way of initiation

8c9ab71

cmsbuild added this to the CMSSW_12_0_X milestone Jul 15, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-pending labels Jul 15, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 15, 2021

Code check

de43f97

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 15, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 15, 2021

cmsbuild added tests-started tests-rejected and removed tests-pending tests-started labels Jul 15, 2021

Correct compilation error

33fd019

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels Jul 15, 2021

cmsbuild added the tests-approved label Jul 16, 2021

civanch reviewed Jul 16, 2021

View reviewed changes

Comment debug

597185c

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Jul 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 16, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 16, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 17, 2021

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Jul 17, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 18, 2021

cmsbuild merged commit eefe5ec into cms-sw:master Jul 18, 2021

cmsbuild mentioned this pull request Jul 19, 2021

[BuildRules] cleanup PYTHON27; use python3 as default cms-sw/cmsdist#7146

Merged

smuzaffar mentioned this pull request Jul 23, 2021

Fix DBG IBs build erros #34602

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gex83A Make a few SD's in SimG4CMS/Forward with the new way of initiation #34507

Run3-gex83A Make a few SD's in SimG4CMS/Forward with the new way of initiation #34507

bsunanda commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

bsunanda commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

civanch commented Jul 15, 2021

civanch commented Jul 15, 2021

civanch Jul 16, 2021

bsunanda Jul 16, 2021

civanch Jul 16, 2021

bsunanda Jul 16, 2021

cmsbuild commented Jul 16, 2021

cmsbuild commented Jul 16, 2021

bsunanda commented Jul 16, 2021

cmsbuild commented Jul 17, 2021

civanch commented Jul 17, 2021

cmsbuild commented Jul 17, 2021

qliphy commented Jul 18, 2021

Run3-gex83A Make a few SD's in SimG4CMS/Forward with the new way of initiation #34507

Run3-gex83A Make a few SD's in SimG4CMS/Forward with the new way of initiation #34507

Conversation

bsunanda commented Jul 15, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

bsunanda commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

Build

civanch commented Jul 15, 2021

civanch commented Jul 15, 2021

civanch Jul 16, 2021

Choose a reason for hiding this comment

bsunanda Jul 16, 2021

Choose a reason for hiding this comment

civanch Jul 16, 2021

Choose a reason for hiding this comment

bsunanda Jul 16, 2021

Choose a reason for hiding this comment

cmsbuild commented Jul 16, 2021

cmsbuild commented Jul 16, 2021

bsunanda commented Jul 16, 2021

cmsbuild commented Jul 17, 2021

Comparison Summary

civanch commented Jul 17, 2021

cmsbuild commented Jul 17, 2021

qliphy commented Jul 18, 2021