-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonicTriton feature updates, improvements, bug fixes #34508
Conversation
…/ TF and ONNX image net examples
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34508/24002 ERROR: Build errors found during clang-tidy run.
|
test parameters: |
the code-checks will not pass until the tests for cms-sw/cmsdist#7142 finish and provide an external build that can be used; then this PR can be tested |
code-checks with cms.week1.PR_5281fe91/46.0-5ad1edc02a2379b0e17209f83d607eda |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34508/24023
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34508/24032
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8905a2/16924/summary.html Comparison SummarySummary:
|
@makortel if there's nothing further, I'd like to get this into pre5. thanks! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@qliphy @perrotta @smuzaffar cms-sw/cmsdist#7142 needs to be merged as well or the IB will break |
@kpedro88 Sorry I overlooked cms-sw/cmsdist#7142 |
cms-sw/cmsdist#7142 is merged now. I ran tests for all archs to make sure that new externals builds fine |
PR description:
toServer()
/fromServer()
more than once per event (bug fix)PR validation:
Ran unit tests and new examples.
This PR requires an associated cmsdist PR (to be submitted simultaneously) to compile: cms-sw/cmsdist#7142