-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pileupCal.py using numpy #34931
Conversation
Tested with a calcMode='true' and a calcMode='observed' example, for the former identical results, for the latter there are some differences the level of 1.e-12
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34931/24742
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34931/24743
|
A new Pull Request was created by @tuthongtran for master. It involves the following packages:
@ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@tuthongtran could you please assign a more meaningful title to your PR? Perhaps, "Update pileupCal.py using numpy" or "Update pileupCal.py for python3" |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3dce7/17859/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Update pileupCal.py using numpy. Works with python3
More details in #34092
PR validation:
tested in CMSSW_12_0_0_pre6
if this PR is a backport please specify the original PR and why you need to backport that PR: