Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-alca197 Add a possible AlCa stream for IsoTrackFilter useful for MC productions #34965

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

bsunanda
Copy link
Contributor

PR description:

Add a possible AlCa stream for IsoTrackFilter useful for MC productions

PR validation:

Tested the new stream using Calibration/HcalAlcaResoProducers/test/AlCaIsoTrackFilterNoHLT_cfg.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34965/24801

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Calibration/HcalAlCaRecoProducers (alca)
  • Configuration/StandardSequences (operations)

@perrotta, @malbouis, @yuanchao, @davidlange6, @cmsbuild, @tlampen, @qliphy, @pohsun, @francescobrivio, @fabiocos, @tvami can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @rovere, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Aug 20, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35c59a/17934/summary.html
COMMIT: 38fcafa
CMSSW: CMSSW_12_1_X_2021-08-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34965/17934/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000352
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000330
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@yuanchao
Copy link
Contributor

+1

  • Add a AlCa stream for IsoTrackFilter (technical)

@perrotta
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • A new AlCa stream is made available for possible future usage

@tvami
Copy link
Contributor

tvami commented Aug 25, 2021

Hi @bsunanda can you please prepare a short talk to discuss the "possible future usage" of this AlCa stream at the next AlCa meeting (Monday, Aug 30)?

@bsunanda
Copy link
Contributor Author

@tvami We are working on improving 2 AlCaReco streams. Hope we shall see some idea in a month's time. Can we make a presentation with our ideas in a months time? This one is relevant for some MC production for HCAL calibration. We can talk on that as well

@tvami
Copy link
Contributor

tvami commented Aug 25, 2021

Hi @bsunanda ok, I added you to the Sept 27 agenda with TBD (https://indico.cern.ch/event/1069948/#2-new-hcal-alca-streams-for-mc), we can come back to the details as this time is approaching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants