Added missing esConsumes to DTTrackFinder

[Dr15Jones]

PR description:

• Added esConsumes to helpers
• Removed an unnecessary base class (which was actually the same name as a class in another package)
• Simplified memory management in L1MuDTSectorProcessor

PR validation:

Code compiles. The changes are not meant to change any behavior.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35080/24961

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/DTTrackFinder/src/L1MuDTAssignmentUnit.cc modified in PR(s): [L1Trigger] Move public headers in to interface directory #34895
  • File L1Trigger/DTTrackFinder/src/L1MuDTAssignmentUnit.h modified in PR(s): [L1Trigger] Move public headers in to interface directory #34895
  • File L1Trigger/DTTrackFinder/src/L1MuDTEtaProcessor.cc modified in PR(s): [L1Trigger] Move public headers in to interface directory #34895
  • File L1Trigger/DTTrackFinder/src/L1MuDTEtaProcessor.h modified in PR(s): [L1Trigger] Move public headers in to interface directory #34895
  • File L1Trigger/DTTrackFinder/src/L1MuDTExtrapolationUnit.cc modified in PR(s): [L1Trigger] Move public headers in to interface directory #34895
  • File L1Trigger/DTTrackFinder/src/L1MuDTSectorProcessor.cc modified in PR(s): [L1Trigger] Move public headers in to interface directory #34895
  • File L1Trigger/DTTrackFinder/src/L1MuDTSectorProcessor.h modified in PR(s): [L1Trigger] Move public headers in to interface directory #34895
  • File L1Trigger/DTTrackFinder/src/L1MuDTSectorReceiver.cc modified in PR(s): [L1Trigger] Move public headers in to interface directory #34895
  • File L1Trigger/DTTrackFinder/src/L1MuDTTrackAssembler.h modified in PR(s): [L1Trigger] Move public headers in to interface directory #34895

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• L1Trigger/DTTrackFinder (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-294b76/18150/summary.html
COMMIT: 6b4ace8
CMSSW: CMSSW_12_1_X_2021-08-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35080/18150/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 17
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000364
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

I fixed the merge conflicts

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35080/24999

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #35080 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-294b76/18216/summary.html
COMMIT: f205243
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35080/18216/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @swagata87 [EGM HLT] Phase out calotower & use HCAL recHits directly #35049
• @bsunanda Run3-sim108 Fully resolve the issue of usinng dd4hep in CherenkovAnalysis #35088
• @makortel Migrate BMixingModule and EcalShapeBase-derived classes to esConsumes #34902
• @perrotta Get rid of the unneeded conf_ class member in SiPixelPhase1EfficiencyExtras #35102
• @ggovi Delete unused headers/test files (DB packages) #34933
• @Dr15Jones Run endStream concurrently as part of endJob #35097
• @smuzaffar [EventFilter] Move private headers in plugins dir; merge plugins cc/h files #34898
• @mariadalfonso NANO: rework for Prompt (part3) #34714
• @guitargeek Merge .h and .cc files of plugins in several PhysicsTools packages #34615
• @TaeunKwon HCAL: fixing pulse containment correction algorithm for Run3 trigger primitives #34805
• @srimanob Fix 2021 Reco Geometry Config files #35092
• @jeongeun Migrate module configuration in PhysicsTools{PatUtils} to use default cfipython #35101
• @makortel Migrate some modules in SimPPS to esConsumes #34989
• @aperloff Updates to the TTTrack/TTTrack_TrackWord DataFormats #34988
• @smuzaffar [L1Trigger] Move public headers in to interface directory #34895
• @bsunanda Run3-sim107 Clean the code - removed the usage of cout and updated the cfg's #35083

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-294b76/18216/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-294b76/18216/git-merge-result

RelVals-INPUT

• 136.72413136.72413_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met.log

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 1505 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 1808
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998573
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 6 / 38 workflows

[qliphy]

please test
test again with new IB

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-294b76/18351/summary.html
COMMIT: f205243
CMSSW: CMSSW_12_1_X_2021-09-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35080/18351/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

ping @cms-sw/l1-l2

[Dr15Jones]

ping @cms-sw/l1-l2

[qliphy]

please test
test again with new IB before merging (bypassing L1 if needed)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-294b76/18533/summary.html
COMMIT: f205243
CMSSW: CMSSW_12_1_X_2021-09-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35080/18533/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[qliphy]

merge