Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS: update scoring plane z positions #35085

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

jan-kaspar
Copy link
Contributor

PR description:

This is a cosmetic PR to make the scoring planes used in PPS simulation consistent with the RP geometry. The maximum correction is 1 mm. Combined with the small angles (wrt. beam) of the forward protons, the effect on the simulated hits is on the micron level, thus negligible. Details are attached here: kaspar_PPS_scoring_planes.pdf

PR validation:

The plots below show comparisons before (blue) and after this PR (red dashed):

  • Run2 data reco workflow: reco_cmp.pdf - no difference observed, as strictly expected
  • "direct simulation" workflow: dirsim_cmp.pdf - no difference observed, as expected due the tiny change

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35085/24965

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

  • Validation/CTPPS (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ec8e/18355/summary.html
COMMIT: 1f2ba68
CMSSW: CMSSW_12_1_X_2021-09-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35085/18355/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000979
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2021

+1

@cmsbuild cmsbuild merged commit c478650 into cms-sw:master Sep 7, 2021
@jan-kaspar jan-kaspar deleted the rp_scoring_planes branch September 27, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants