-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL esConsumes migration various packages #35149
ECAL esConsumes migration various packages #35149
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35149/25068
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages:
@ggovi, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd61d5/18305/summary.html Comparison SummarySummary:
|
+1 |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR migrates ECAL related code in the various reco and db packages to esConsumes (#31061). In addition
getByLabel()
calls were replaced bygetByToken()
and legacy module types were migrated to multithreaded module types.PR validation:
Code compiles.