modernize Alignment/TrackerAlignment

[mmusich]

PR description:

Modernize Alignment/TrackerAlignment:

• merge headers with plugin implementation
• transformed legacy EDModules into thread-safe versions
• move cout to thread-safe MessageLogger instructions
• remove commented out code
• add fillDescriptions methods

PR validation:

It compiles, also tested with unit tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35254/25233

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/TrackerAlignment (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[tvami]

Cosmetic comments about std::endl, std::flush and in general about the inclusion of std namespace in the code.

[mmusich]

@tvami,
I have tested removal of the std::endl at the end of LogDebug statements and found no functional difference in the output. About inclusion of using namespace std I don't find any discouraging remark here.
As there is no added value in the comments proposed, I choose to ignore them.

[tvami]

@tvami,
I have tested removal of the std::endl at the end of LogDebug statements and found no functional difference in the output. About inclusion of using namespace std I don't find any discouraging remark here.
As there is no added value in the comments proposed, I choose to ignore them.

Ok, that's fine, it was all cosmetic.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f961/18565/summary.html
COMMIT: 68e0b79
CMSSW: CMSSW_12_1_X_2021-09-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35254/18565/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000973
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1