Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable G4GammaGeneralProcess #35287

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Sep 15, 2021

PR description:

Gamma general process is disable in order to have the same configuration in 12_0 and 12_1. We can try to enable it only when Geant4 10.7p02 will be merged.

Simulation histories will be changed due to this PR.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35287/25290

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

  • SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Sep 15, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a20b7e/18629/summary.html
COMMIT: f614593
CMSSW: CMSSW_12_1_X_2021-09-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35287/18629/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 55245 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000833
  • DQMHistoTests: Total failures: 290944
  • DQMHistoTests: Total nulls: 250
  • DQMHistoTests: Total successes: 2709617
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.756 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.192 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.064 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.111 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -3.995 KiB SiStrip/MechanicalView
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 13 / 38 workflows

@civanch
Copy link
Contributor Author

civanch commented Sep 16, 2021

+1

regression is not expected. This PR would be good to have in pre3

@civanch
Copy link
Contributor Author

civanch commented Sep 16, 2021

urgent

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Gamma general process is disabled following the decision taken by Simulation and PPD
  • 12_0_X and 12_1_X will get the same configuration, then; difference will be expected while comparing pre3 and pre4 relvals

@cmsbuild cmsbuild merged commit dadd3a7 into cms-sw:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants