Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0.X] add onlineBeamSpotESProducer to BeamSpot_cfi: fix general Online BS swap case #35653

Merged
merged 3 commits into from
Oct 16, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 13, 2021

backport of #35639

PR description:

In PR #35373 the general case for the online <-> offline BS swap done via modifiers was missed, leading to issues in the visualization DQM clients.
This PR supplies the onlineBeamSpotESProducer to BeamSpot_cfi as a general case fix-up.

PR validation:

Run cmsRun DQM/Integration/python/clients/visualization-live_cfg.py unitTest=True
that before was crashing with:

...
Exception Message:
No "BeamSpotTransientObjectsRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

while now crashes differently with:

----- Begin Fatal Exception 13-Oct-2021 10:41:57 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 334393 lumi: 1 event: 16132 stream: 1
   [1] Running path 'FEVToutput_step'
   [2] Prefetching for module JsonWritingTimeoutPoolOutputModule/'FEVToutput'
   [3] Prefetching for module ReducedRecHitCollectionProducer/'reducedEcalRecHitsEB'
   [4] Prefetching for module EleIsoDetIdCollectionProducer/'interestingGedEleIsoDetIdEB'
   [5] Calling method for module GEDGsfElectronFinalizer/'gedGsfElectrons'
Exception Message:
No data of type "GBRForestD" with label "electron_eb_ecalOnly_1To300_0p2To2_mean" in record "GBRDWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backported from #35639

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

  • RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @dgulhan, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Oct 13, 2021

@cmsbuild , please test with #35561

@tvami
Copy link
Contributor

tvami commented Oct 13, 2021

@cmsbuild please abort

@tvami
Copy link
Contributor

tvami commented Oct 13, 2021

test parameters:

@tvami
Copy link
Contributor

tvami commented Oct 13, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6d601/19607/summary.html
COMMIT: 7527bdc
CMSSW: CMSSW_12_0_X_2021-10-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35653/19607/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Oct 13, 2021

+alca

@cmsbuild
Copy link
Contributor

Pull request #35653 was updated. @malbouis, @yuanchao, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2021

in the last commit, I've just fixed the typo spotted by @perrotta at #35639 (comment)

@tvami
Copy link
Contributor

tvami commented Oct 15, 2021

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Oct 15, 2021

+alca

  • last commit was just a typo

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6d601/19666/summary.html
COMMIT: f302c38
CMSSW: CMSSW_12_0_X_2021-10-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35653/19666/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Oct 15, 2021

+reconstruction

for #35653 f302c38

  • code changes since the last reco signoff are just a typo fix in the method name

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 89a9a40 into cms-sw:CMSSW_12_0_X Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants