-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0.X] add onlineBeamSpotESProducer to BeamSpot_cfi: fix general Online BS swap case #35653
[12.0.X] add onlineBeamSpotESProducer to BeamSpot_cfi: fix general Online BS swap case #35653
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please abort |
test parameters: |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6d601/19607/summary.html Comparison SummarySummary:
|
+alca |
in the last commit, I've just fixed the typo spotted by @perrotta at #35639 (comment) |
@cmsbuild , please test |
+alca
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6d601/19666/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
backport of #35639
PR description:
In PR #35373 the general case for the online <-> offline BS swap done via modifiers was missed, leading to issues in the visualization DQM clients.
This PR supplies the
onlineBeamSpotESProducer
toBeamSpot_cfi
as a general case fix-up.PR validation:
Run
cmsRun DQM/Integration/python/clients/visualization-live_cfg.py unitTest=True
that before was crashing with:
while now crashes differently with:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backported from #35639